| dhaumann |
| KTextEditor |
After
https://bugs.kde.org/show_bug.cgi?id=360456
https://cgit.kde.org/ktexteditor.git/commit/?id=58baf7c318d4641a243ea18f04ef15ee017509e3
the align of doxygen comments in templates stopped working.
Without the patch:
/** * foo */ void foo();
with the patch:
/** * foo */ void foo();
Original test:
-> not properly align
Newly added testcase:
Old test:
| Lint Skipped |
| Unit Tests Skipped |
Hi, thanks for the patch to improve the indentation handling.
A case to reproduce would help.
For me, the identation is messed up in Kate if I do indent/unindent of such comments and the "keep extra spaces" option is off.
But I think that has nothing to do with this bug.
For the code:
Hmm, why do you use rtrim? That removes trailing spaces, that won't help the startsWith checks. Or do I misread that?
This did not work for templates as "isComment" uses line attributes and at the time the template is inserted it is always "C/C++ Code/Data"-attribute never a comment. It only becomes a "doxygen comment"-attribute after the template "editing" is finished.
Changed to (correct) ktexteditor repository. Someday... I will learn how to use phabricator :)
Well, make test works for me, and if this fixes the issue for you, I'm fine with that.
Locally, I had to resolve one hunk that did not apply. Maybe you have to update the patch again.
Can you commit yourself, or shall I push?
Thx for the review :)
I will update the patch (and post it here again).
I can commit it myself, to master? or any special branch?
EDIT: as ktexteditor git only has a master, I will go ahead and push it to master.