buschinski (Bernd Buschinski)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 13 2018, 1:21 PM (57 w, 6 d)
Availability
Available

Recent Activity

Jul 19 2019

buschinski committed R32:d1f585620464: Fix code completion for nameless structs/unions with the same member (authored by buschinski).
Fix code completion for nameless structs/unions with the same member
Jul 19 2019, 5:22 PM
buschinski closed D22455: Fix code completion for nameless structs/unions with the same member.
Jul 19 2019, 5:21 PM · KDevelop
buschinski updated the summary of D22455: Fix code completion for nameless structs/unions with the same member.
Jul 19 2019, 4:16 PM · KDevelop

Jul 14 2019

buschinski requested review of D22455: Fix code completion for nameless structs/unions with the same member.
Jul 14 2019, 2:43 PM · KDevelop

Oct 31 2018

buschinski requested review of D16541: Increase timeout for duchain gcc compatibility test.
Oct 31 2018, 1:05 PM · KDevelop
buschinski committed R32:808adc410936: Merge remote-tracking branch 'origin/5.3' (authored by buschinski).
Merge remote-tracking branch 'origin/5.3'
Oct 31 2018, 12:52 PM
buschinski committed R32:3c51faa280ab: FunctionDefinition: only look for (new/other) function definition if we don't… (authored by buschinski).
FunctionDefinition: only look for (new/other) function definition if we don't…
Oct 31 2018, 12:43 PM
buschinski closed D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.
Oct 31 2018, 12:42 PM · KDevelop
buschinski committed R32:c3c30113bd8f: Fix memleaks in duchain unittests (authored by buschinski).
Fix memleaks in duchain unittests
Oct 31 2018, 12:40 PM
buschinski closed D16458: Fix memleaks in duchain unittests.
Oct 31 2018, 12:40 PM · KDevelop
buschinski updated the diff for D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.

Updated. Thanks! I will push it :)

Oct 31 2018, 12:36 PM · KDevelop

Oct 29 2018

buschinski updated the diff for D16458: Fix memleaks in duchain unittests.
  • changed as requested, will push tomorrow or so
Oct 29 2018, 9:43 PM · KDevelop
buschinski updated the diff for D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.
  • Initial test, works with the patch, fails without :)
Oct 29 2018, 9:40 PM · KDevelop

Oct 27 2018

buschinski requested review of D16458: Fix memleaks in duchain unittests.
Oct 27 2018, 2:16 PM · KDevelop
buschinski added a comment to D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.

I assume you ran the tests (esp. for clang?) and it all keeps passing? if so, then +1

+2 if you could write a proper test for the case you explained in your commit message

Oct 27 2018, 1:33 PM · KDevelop

Oct 22 2018

buschinski updated the diff for D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.
  • updated based on the suggestions from Milian Wolff
Oct 22 2018, 5:41 PM · KDevelop

Oct 21 2018

buschinski requested review of D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.
Oct 21 2018, 3:48 PM · KDevelop
buschinski added a comment to D16064: Fix memleaks in unittests.

Sorry, forgot to push it. Should it go to 5.3 or master?

Oct 21 2018, 1:22 PM · KDevelop
buschinski committed R39:4bf7fee92a37: Fix align of doxygen comments in templates (authored by buschinski).
Fix align of doxygen comments in templates
Oct 21 2018, 1:12 PM
buschinski closed D16018: Fix align of doxygen comments in templates.
Oct 21 2018, 1:05 PM · Frameworks, Kate
buschinski updated the diff for D16018: Fix align of doxygen comments in templates.
  • updated again master
  • mentioned templates in commit title
Oct 21 2018, 9:45 AM · Frameworks, Kate
buschinski added a comment to D16018: Fix align of doxygen comments in templates.

Thx for the review :)
I will update the patch (and post it here again).

Oct 21 2018, 9:40 AM · Frameworks, Kate

Oct 9 2018

buschinski added inline comments to D16064: Fix memleaks in unittests.
Oct 9 2018, 10:08 AM · KDevelop
buschinski requested review of D16064: Fix memleaks in unittests.
Oct 9 2018, 9:04 AM · KDevelop
buschinski updated the diff for D16018: Fix align of doxygen comments in templates.

Changed to (correct) ktexteditor repository. Someday... I will learn how to use phabricator :)

Oct 9 2018, 8:54 AM · Frameworks, Kate

Oct 7 2018

buschinski changed the repository for D16018: Fix align of doxygen comments in templates from R32 KDevelop to R39 KTextEditor.
Oct 7 2018, 10:06 PM · Frameworks, Kate
buschinski added a comment to D16018: Fix align of doxygen comments in templates.

This did not work for templates as "isComment" uses line attributes and at the time the template is inserted it is always "C/C++ Code/Data"-attribute never a comment. It only becomes a "doxygen comment"-attribute after the template "editing" is finished.

Oct 7 2018, 10:05 PM · Frameworks, Kate
buschinski updated the diff for D16018: Fix align of doxygen comments in templates.
Oct 7 2018, 10:03 PM · Frameworks, Kate
buschinski added a comment to D16018: Fix align of doxygen comments in templates.

...
For the code:
Hmm, why do you use rtrim? That removes trailing spaces, that won't help the startsWith checks. Or do I misread that?

Oct 7 2018, 9:56 PM · Frameworks, Kate
buschinski requested review of D16018: Fix align of doxygen comments in templates.
Oct 7 2018, 3:47 PM · Frameworks, Kate
buschinski committed R32:e3ec1d531eb4: Merge remote-tracking branch 'origin/5.3' (authored by buschinski).
Merge remote-tracking branch 'origin/5.3'
Oct 7 2018, 1:52 PM
buschinski committed R32:f223280b1097: Sort Project Targets in Launch configuration (authored by buschinski).
Sort Project Targets in Launch configuration
Oct 7 2018, 1:49 PM
buschinski closed D16003: Sort Project Targets in Launch configuration.
Oct 7 2018, 1:48 PM · KDevelop
buschinski committed R32:6da2caac877d: Fix discovery of clang builtin directory with clang svn versions (authored by buschinski).
Fix discovery of clang builtin directory with clang svn versions
Oct 7 2018, 1:47 PM
buschinski closed D15998: Fix discovery of clang builtin directory with clang svn versions.
Oct 7 2018, 1:47 PM · KDevelop
buschinski requested review of D16003: Sort Project Targets in Launch configuration.
Oct 7 2018, 10:41 AM · KDevelop
buschinski requested review of D15998: Fix discovery of clang builtin directory with clang svn versions.
Oct 7 2018, 9:44 AM · KDevelop

Oct 4 2018

buschinski committed R32:716372ae2e8d: Use CLANG_INCLUDE_DIRS for clang include dir (authored by buschinski).
Use CLANG_INCLUDE_DIRS for clang include dir
Oct 4 2018, 6:36 PM
buschinski closed D15895: Use CLANG_INCLUDE_DIRS for clang include dir.
Oct 4 2018, 6:36 PM · KDevelop
buschinski updated the diff for D15895: Use CLANG_INCLUDE_DIRS for clang include dir.

Used PATH_SUFFIXES to cleanup the find_path a bit more

Oct 4 2018, 1:27 PM · KDevelop
buschinski added inline comments to D15895: Use CLANG_INCLUDE_DIRS for clang include dir.
Oct 4 2018, 1:26 PM · KDevelop

Oct 3 2018

buschinski updated the diff for D15895: Use CLANG_INCLUDE_DIRS for clang include dir.

Added additional search PATHS with CLANG_LIBRARY_DIRS, like it was used in the original version (without this patch). This should hopefully work on opensuse as well.

Oct 3 2018, 2:25 PM · KDevelop
buschinski added a comment to D15895: Use CLANG_INCLUDE_DIRS for clang include dir.

"cpuid.h" on my system is in (listing ALL locations):

  • /usr/lib64/clang/7.0.0/include/cpuid.h
  • /usr/lib64/gcc/x86_64-pc-linux-gnu/7.3.0/include/cpuid.h
  • /usr/lib64/gcc/x86_64-pc-linux-gnu/8.2.0/include/cpuid.h
  • and a few in /usr/src/linux-* (linux kernel sources)
Oct 3 2018, 2:01 PM · KDevelop

Oct 2 2018

buschinski updated the diff for D15895: Use CLANG_INCLUDE_DIRS for clang include dir.

Sorry, you are right. I forgot the most important part of the patch. Sorry for the noise :(

Oct 2 2018, 3:17 PM · KDevelop
buschinski updated the summary of D15895: Use CLANG_INCLUDE_DIRS for clang include dir.
Oct 2 2018, 1:40 PM · KDevelop
buschinski requested review of D15895: Use CLANG_INCLUDE_DIRS for clang include dir.
Oct 2 2018, 1:37 PM · KDevelop

Aug 14 2018

buschinski committed R32:dcd83bca4b0d: Merge remote-tracking branch 'origin/5.2' (authored by buschinski).
Merge remote-tracking branch 'origin/5.2'
Aug 14 2018, 7:00 PM
buschinski committed R32:04f522f55c4f: Fix last > rowCount() assert in ClassModel Node dtor (authored by buschinski).
Fix last > rowCount() assert in ClassModel Node dtor
Aug 14 2018, 6:51 PM
buschinski closed D14840: Fix last > rowCount() assert in ClassModel Node dtor.
Aug 14 2018, 6:50 PM · KDevelop
buschinski requested review of D14840: Fix last > rowCount() assert in ClassModel Node dtor.
Aug 14 2018, 3:21 PM · KDevelop

Aug 13 2018

buschinski added a reviewer for D14791: Fix assert in ClassModel::nodesRemoved: KDevelop.
Aug 13 2018, 1:38 PM · KDevelop
buschinski requested review of D14791: Fix assert in ClassModel::nodesRemoved.
Aug 13 2018, 1:38 PM · KDevelop