| scottpetrovic | |
| rempt |
| Krita | |
| VDG |
In order to adjust selected curve point accurately, spin boxes are added
on x and y domain. Selected curve point can be re-positioned by editing
these spin boxes.
For non-numeric values and where the maximum value is 1.0, percentage
is used; for time values in seconds, milliseconds is used. In
order to emphasize this, suffixes are added to spin boxes.
BUG: 396528
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
This seems like it works perfect for me. I am approving it on my end.
From a committer standpoint, we will have to figure out out to merge things if/when this gets approved. We have 3 brush editor change sets right now that are going to all have conflicts.
Instead of duplicating the code over and over, you should consider to add default values in the parent class.
Wouldn't it be possible to use the real min and max values instead of adding a new min/max?
Yes, I agree with slangkamp: this kind of code duplication is something we want to avoid.
Thank you very much for your prompt review and comments.
For code duplications, I made them pure virtual in order to force new inheritance to be aware of these methods. If there won't be a problem for new inheritance, I can add default values (mostly 0-100 and %) in the base class. Please advice.
For real min/max values; unfortunately, real min/max values usually do not match with the y_min and y_max labels (for example, real values are 0.0 and 1.0 but, labels are -180° and 180°).
Common usage moved to base and duplicated overrides removed.
Spaces between suffixes and values are edited.
There still some cleaning up to do; all the places where the only change is whitespace shouldn't be in the patch. I haven't got problems with the actual code anymore, other than stylistic issues. Please fix those, and then let's merge it :-)
| plugins/paintops/libpaintop/kis_pressure_hsv_option.cpp | ||
|---|---|---|
| 152 | Coding style: space between if and (, and brackets on the same line as the if statement. See https://community.kde.org/Policies/Kdelibs_Coding_Style#Braces . | |