User Details
- User Since
- Oct 7 2018, 9:34 AM (285 w, 5 d)
- Availability
- Available
Dec 25 2018
I am sorry, I could not continue to edit this revision.
Nov 14 2018
Hi @dkazakov,
I think naming causing some misunderstandings, therefore I edited control name (please refer to videos).
For the issues you mentioned:
1-5. I think this is a normal behavior. If you save a dirty preset, you save edited option as new preset so, you can not see the dirty flag when you re-select it. Please refer to the video below. First, I changed another option and save it, then repeat it with color option. They behave the same.
Nov 11 2018
Sorry for my late reply, I was busy this week.
On my first implementation, I tried not to change the current preset before saving or overwriting. I changed this behavior and made some changes for the preset dirty state.
Nov 1 2018
No problem at my side. This request has been waiting for about 4 years so, it can wait a bit more. ^_^b
Oct 28 2018
I change whole revision and edit current revision title and summary. Please also check new video on summary how this new revision works. Please advise any problem you notice.
Oct 25 2018
Yes, this is confusing, so how about, if we disable color picker on tool bar (if this only effects brush color) when fixed colored brush preset selected, and re-enable it when an other brush preset without fixed color selected? This way, we revert back the previous color when an other preset selected. And also by disabling the color picker on tool bar, user can notice that the current brush is fixed color one.
Oct 21 2018
I added Copyright notices and create diff again, however, this is already committed therefore, let me know if I should create only copyright diffs.
Copyright notices added
Sorry, this is my first open source project contribution, I forgot to add one. And, I don't know how it is written. I can copy from an other file but, whose e-mail should be written on top, mine, dkazakov or both ?
Oct 20 2018
This is how it works.
Well, this will be a fixed color brush and it will not be effected by system color options (color picker on tool bar). I will try to upload a short video, how its work.
Thank you for your review.
Oct 15 2018
I am not sure about these two parts below
Oct 10 2018
Whitespace commits are removed,
Coding style is fixed.
Oct 8 2018
Common usage moved to base and duplicated overrides removed.
Spaces between suffixes and values are edited.
Oct 7 2018
Thank you very much for your prompt review and comments.