mscaliskan (M. Salih Çalışkan)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2018, 9:34 AM (285 w, 5 d)
Availability
Available

Recent Activity

Dec 25 2018

mscaliskan abandoned D16234: Save current color with brush preset.
Dec 25 2018, 8:02 AM · Krita
mscaliskan added a comment to D16234: Save current color with brush preset.

I am sorry, I could not continue to edit this revision.

Dec 25 2018, 8:02 AM · Krita

Nov 14 2018

mscaliskan updated the diff for D16234: Save current color with brush preset.

Hi @dkazakov,
I think naming causing some misunderstandings, therefore I edited control name (please refer to videos).
For the issues you mentioned:
1-5. I think this is a normal behavior. If you save a dirty preset, you save edited option as new preset so, you can not see the dirty flag when you re-select it. Please refer to the video below. First, I changed another option and save it, then repeat it with color option. They behave the same.

Nov 14 2018, 8:04 PM · Krita

Nov 11 2018

mscaliskan updated the diff for D16234: Save current color with brush preset.

Sorry for my late reply, I was busy this week.
On my first implementation, I tried not to change the current preset before saving or overwriting. I changed this behavior and made some changes for the preset dirty state.

Nov 11 2018, 4:14 PM · Krita

Nov 1 2018

mscaliskan added a comment to D16234: Save current color with brush preset.

No problem at my side. This request has been waiting for about 4 years so, it can wait a bit more. ^_^b

Nov 1 2018, 4:21 PM · Krita

Oct 28 2018

mscaliskan updated the diff for D16234: Save current color with brush preset.

I change whole revision and edit current revision title and summary. Please also check new video on summary how this new revision works. Please advise any problem you notice.

Oct 28 2018, 10:06 PM · Krita
mscaliskan updated the summary of D16234: Save current color with brush preset.
Oct 28 2018, 10:00 PM · Krita

Oct 25 2018

mscaliskan added a comment to D16234: Save current color with brush preset.

I would prefer to allow the user to use all the existing color selectors for this change. I can bet that no painter will ever enter that "color source" tab voluntary :) The interactions should be much simpler.

E.g.:

  1. Check a check box "Save brush color"
  2. Select the color using any existing color selection method.
Oct 25 2018, 1:34 PM · Krita
mscaliskan added a comment to D16234: Save current color with brush preset.

Yes, this is confusing, so how about, if we disable color picker on tool bar (if this only effects brush color) when fixed colored brush preset selected, and re-enable it when an other brush preset without fixed color selected? This way, we revert back the previous color when an other preset selected. And also by disabling the color picker on tool bar, user can notice that the current brush is fixed color one.

Oct 25 2018, 11:44 AM · Krita

Oct 21 2018

mscaliskan reopened D16119: Paste plain text as selected text style on SVG text tool.

I added Copyright notices and create diff again, however, this is already committed therefore, let me know if I should create only copyright diffs.

Oct 21 2018, 4:43 PM · Krita
mscaliskan updated the diff for D16119: Paste plain text as selected text style on SVG text tool.

Copyright notices added

Oct 21 2018, 4:34 PM · Krita
mscaliskan added a comment to D16119: Paste plain text as selected text style on SVG text tool.

Sorry, this is my first open source project contribution, I forgot to add one. And, I don't know how it is written. I can copy from an other file but, whose e-mail should be written on top, mine, dkazakov or both ?

Oct 21 2018, 7:56 AM · Krita

Oct 20 2018

mscaliskan added a comment to D16234: Save current color with brush preset.

This is how it works.

Oct 20 2018, 6:49 PM · Krita
mscaliskan added a comment to D16234: Save current color with brush preset.

Well, this will be a fixed color brush and it will not be effected by system color options (color picker on tool bar). I will try to upload a short video, how its work.

Oct 20 2018, 6:25 PM · Krita
mscaliskan added a comment to D16234: Save current color with brush preset.

Thank you for your review.

Oct 20 2018, 3:22 PM · Krita

Oct 15 2018

mscaliskan added a comment to D16234: Save current color with brush preset.

I am not sure about these two parts below

Oct 15 2018, 8:28 PM · Krita
mscaliskan requested review of D16234: Save current color with brush preset.
Oct 15 2018, 8:24 PM · Krita

Oct 10 2018

mscaliskan requested review of D16119: Paste plain text as selected text style on SVG text tool.
Oct 10 2018, 9:23 PM · Krita
mscaliskan updated the diff for D16008: Adjust selected curve point more accurately by using spin boxes.

Whitespace commits are removed,
Coding style is fixed.

Oct 10 2018, 7:04 PM · Krita

Oct 8 2018

mscaliskan updated the diff for D16008: Adjust selected curve point more accurately by using spin boxes.

Common usage moved to base and duplicated overrides removed.
Spaces between suffixes and values are edited.

Oct 8 2018, 5:26 PM · Krita

Oct 7 2018

mscaliskan added a comment to D16008: Adjust selected curve point more accurately by using spin boxes.

Thank you very much for your prompt review and comments.

Oct 7 2018, 8:11 PM · Krita
mscaliskan updated the summary of D16008: Adjust selected curve point more accurately by using spin boxes.
Oct 7 2018, 12:09 PM · Krita
mscaliskan updated the summary of D16008: Adjust selected curve point more accurately by using spin boxes.
Oct 7 2018, 12:08 PM · Krita
mscaliskan requested review of D16008: Adjust selected curve point more accurately by using spin boxes.
Oct 7 2018, 12:06 PM · Krita