Start drawing emblems in the bottom-right corner
ClosedPublic

Authored by ngraham on Oct 4 2018, 4:01 PM.

Details

Summary

While writing a HIG page about emblems (D15897), we noticed an inconsistency in where they're currently placed: All of our icons that have built-in emblems as well as all 3rd-party system tray icons put their emblems in the bottom-right corner. But when KIconLoader it used to add emblems to a regular icon, it puts the first emblem in the bottom-left corner.

This arbitrary inconsistency makes it impossible to write a clear rule in the HIG about emblem placement. Changing hundreds of icons and 3rd-party apps to move all their emblems to the bottom-right corner doesn't seem likely. Therefore, this patch adjusts 'KIconLoader` to position the first emblem in the bottom-right corner to match existing icons and 3rd-party apps.

Test Plan

Symlink emblem:

Shared folder emblem:

Emblem on a disk in the Places panel:

Folders with multiple emblems:

Diff Detail

Repository
R302 KIconThemes
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Oct 4 2018, 4:01 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 4 2018, 4:01 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 4 2018, 4:01 PM
ngraham edited the test plan for this revision. (Show Details)Oct 4 2018, 4:04 PM
dfaure accepted this revision.Oct 7 2018, 12:43 PM
This revision is now accepted and ready to land.Oct 7 2018, 12:43 PM
This revision was automatically updated to reflect the committed changes.