--pop up positioning that was introduced in order to a dock
pop up to not be placed far for the item triggering the pop up
broke the plasma panel pop-ups placement in !compositing mode
because plasma panels are also setting a mask in !compositing
mode. This fix tries to fix the situation for plasma panels
and also keep the functionality needed by docks.
--The tooltips exception for !compositing mode is added because
docks might also want to place their tooltips not according to
window geometry or mask but according to their inner elements.
Details
Details
- Reviewers
broulik davidedmundson - Group Reviewers
Plasma
test plasma panels in compositing and !compositing in order to
confirm functionality
test Latte dock in order to confirm that popups are still placed
correctly
test Latte dock tooltips in !compositing mode in order to confirm
that can be placed inside the window or mask boundaries
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Branch
- maskPositioning
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 3321 Build 3339: arc lint + arc unit
Comment Actions
[BEFORE: popup placement in plasma panel in !compositing]
[AFTER: popup placement in plasma panel in !compositing]
[BEFORE: popup placement in plasma panel in !compositing]
[AFTER: popup placement in plasma panel in !compositing]
| src/plasmaquick/dialog.cpp | ||
|---|---|---|
| 910 | This positions the plasma taskmanager previews a bit out of place because plasma panels are enforcing 2px margin at their edges. What type of window do you believe should be an exception in order for the popup to be placed according to the item that triggered it? | |