Differential D1582

Move the OpenGL unsafe check into the Platform
ClosedPublic
Actions

Authored by graesslin on May 10 2016, 8:39 AM.

Details

Reviewers

mart

Group Reviewers

Plasma

Commits

R108:7c822fadeecf: Move the OpenGL unsafe check into the Platform

Summary

A new virtual method createOpenGLSafePoint is added to Platform.
This is invoked through the Compositor with a PreInit and a PostInit
argument pre and post creating the SceneOpenGL.

The Platform plugin can implement this and use it for detecting whether
creating the OpenGL compositor on this platform crashed in the past.
Thus it's the base for the openGLIsBroken platform check.

The x11 standalone plugin is the first to implement this functionality
using the previous code which was designed for X11.

This also means that a crash of the OpenGL compositor during init on
Wayland won't result in OpenGL being disabled.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 3744.May 10 2016, 8:39 AM

graesslin retitled this revision from to Move the OpenGL unsafe check into the Platform.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added a reviewer: Plasma.

Restricted Application added a project: Plasma. · View Herald TranscriptMay 10 2016, 8:39 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

graesslin added dependencies: D1581: If glx is not available try to create egl backend, D1576: Provide functionality of CompositingPrefs through Platform, D1575: Move requiresCompositing from Application to Platform.May 10 2016, 8:39 AM

mart accepted this revision.May 17 2016, 12:13 PM

mart added a reviewer: mart.

This revision is now accepted and ready to land.May 17 2016, 12:13 PM

Closed by commit R108:7c822fadeecf: Move the OpenGL unsafe check into the Platform (authored by graesslin). · Explain WhyMay 17 2016, 12:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			composite.cpp (11 lines)
M			platform.h (14 lines)
M			platform.cpp (5 lines)
M			plugins/platforms/x11/standalone/x11_platform.h (1 line)
M			plugins/platforms/x11/standalone/x11_platform.cpp (15 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3744	2b9066d		May 10 2016, 8:39 AM	★	★
Diff 2	3846	48e69b7	rKWIN7c822fadeecf4875f6b06593bf2c053f4df312c8	May 17 2016, 12:29 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
a5a63680e6ed	fe0d388221b8	2b9066d71936	Martin Gräßlin	Move the OpenGL unsafe check into the Platform (Show More…)	May 10 2016, 8:34 AM

Status	Author	Revision
Closed	graesslin	D1582 Move the OpenGL unsafe check into the Platform
Closed	graesslin	D1581 If glx is not available try to create egl backend
Closed	graesslin	D1576 Provide functionality of CompositingPrefs through Platform
Closed	graesslin	D1575 Move requiresCompositing from Application to Platform