Differential D1575

Move requiresCompositing from Application to Platform
ClosedPublic
Actions

Authored by graesslin on May 9 2016, 2:43 PM.

Details

Reviewers

davidedmundson

Group Reviewers

Plasma

Commits

R108:c45942a70c6a: Move requiresCompositing from Application to Platform

Summary

This change reduces the windowing system specific code pathes. Instead
of checking whether we are on X11 or Wayland to decide whether
compositing is required, we just ask the Platform.

The default is true, only x11 standalone allows to not require
compositing.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 3726.May 9 2016, 2:43 PM

graesslin retitled this revision from to Move requiresCompositing from Application to Platform.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added a reviewer: Plasma.

Restricted Application added a project: Plasma. · View Herald TranscriptMay 9 2016, 2:43 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

graesslin added a dependent revision: D1581: If glx is not available try to create egl backend.May 10 2016, 8:19 AM

graesslin added a dependent revision: D1582: Move the OpenGL unsafe check into the Platform.May 10 2016, 8:39 AM

davidedmundson accepted this revision.May 17 2016, 11:34 AM

davidedmundson added a reviewer: davidedmundson.

This revision is now accepted and ready to land.May 17 2016, 11:34 AM

Closed by commit R108:c45942a70c6a: Move requiresCompositing from Application to Platform (authored by graesslin). · Explain WhyMay 17 2016, 12:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			composite.cpp (10 lines)
M			main.h (1 line)
M			main.cpp (5 lines)
M			options.h (8 lines)
M			options.cpp (12 lines)
M			platform.h (7 lines)
M			platform.cpp (5 lines)
M			plugins/platforms/x11/standalone/x11_platform.h (1 line)
M			plugins/platforms/x11/standalone/x11_platform.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3726	bd8f6d7		May 9 2016, 2:43 PM	★	★
Diff 2	3841	73fae5e	rKWINc45942a70c6ab90a0260164b69f5ed8876e63c3e	May 17 2016, 11:59 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
51170f62f5ef	bbf7b70b3a8b	bd8f6d78f073	Martin Gräßlin	Move requiresCompositing from Application to Platform (Show More…)	May 9 2016, 2:41 PM

Status	Author	Revision
Closed	graesslin	D1582 Move the OpenGL unsafe check into the Platform
Closed	graesslin	D1581 If glx is not available try to create egl backend
Closed	graesslin	D1576 Provide functionality of CompositingPrefs through Platform
Closed	graesslin	D1575 Move requiresCompositing from Application to Platform