Differential D1576

Provide functionality of CompositingPrefs through Platform
ClosedPublic
Actions

Authored by graesslin on May 9 2016, 3:36 PM.

Details

Reviewers

davidedmundson

Group Reviewers

Plasma

Commits

R108:d15d3a5ff12c: Provide functionality of CompositingPrefs through Platform

Summary

CompositingPrefs is only relevant for X11 standalone. It had some
"hacks" to make it not block Compositing on Wayland. Thus it was in
its current form not really useful.

Now all the functionality is provided through Platform with a default
implementation which is sensible for Wayland platforms.

The X11 standalone platform implements the new methods with the
Wayland checks removed.

In addition all calls to CompositingPrefs now go through the platform
directly and CompositingPrefs is completely dropped.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 3727.May 9 2016, 3:36 PM

graesslin retitled this revision from to Provide functionality of CompositingPrefs through Platform.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added a reviewer: Plasma.

Restricted Application added a project: Plasma. · View Herald TranscriptMay 9 2016, 3:36 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

graesslin added a dependent revision: D1581: If glx is not available try to create egl backend.May 10 2016, 8:19 AM

graesslin added a dependent revision: D1582: Move the OpenGL unsafe check into the Platform.May 10 2016, 8:39 AM

davidedmundson accepted this revision.May 17 2016, 11:40 AM

davidedmundson added a reviewer: davidedmundson.

This revision is now accepted and ready to land.May 17 2016, 11:40 AM

Closed by commit R108:d15d3a5ff12c: Provide functionality of CompositingPrefs through Platform (authored by graesslin). · Explain WhyMay 17 2016, 12:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (1 line)
M		composite.cpp (5 lines)
D	M	compositingprefs.h (59 lines)
D	M	compositingprefs.cpp (129 lines)
M		dbusinterface.cpp (8 lines)
M		options.cpp (1 line)
M		platform.h (24 lines)
M		platform.cpp (15 lines)
M		plugins/platforms/x11/standalone/x11_platform.h (15 lines)
M		plugins/platforms/x11/standalone/x11_platform.cpp (75 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3727	47a3fad		May 9 2016, 3:36 PM	★	★
Diff 2	3842	c45942a	rKWINd15d3a5ff12ca6a6e66ee8e087fd7a795ce3c25f	May 17 2016, 11:59 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
24b02d786c89	7c2eb22d2490	47a3fad004b7	Martin Gräßlin	Provide functionality of CompositingPrefs through Platform (Show More…)	May 9 2016, 3:32 PM

Status	Author	Revision
Closed	graesslin	D1582 Move the OpenGL unsafe check into the Platform
Closed	graesslin	D1581 If glx is not available try to create egl backend
Closed	graesslin	D1576 Provide functionality of CompositingPrefs through Platform
Closed	graesslin	D1575 Move requiresCompositing from Application to Platform