Add tooltips to krunner configure and close buttons
ClosedPublic

Authored by slenz on Sep 25 2018, 5:40 PM.

Details

Summary

Shows tooltips for buttons left and right of the search box.

FEATURE: 398943

Test Plan

Manually test appearance of tooltips, unlikely to cause new issues.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
slenz created this revision.Sep 25 2018, 5:40 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 25 2018, 5:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
slenz requested review of this revision.Sep 25 2018, 5:40 PM
slenz edited the summary of this revision. (Show Details)Sep 25 2018, 5:41 PM
ngraham added a subscriber: ngraham.

Wow, that was fast. One minor suggestion:

lookandfeel/contents/runcommand/RunCommand.qml
64

Needs ellipses; see https://hig.kde.org/style/writing/labels.html#using-ellipses-in-labels

How about "Configure KRunner..." ?

slenz updated this revision to Diff 42318.Sep 25 2018, 6:55 PM

Add ellipses and KRunner to configure tooltip.

slenz added inline comments.Sep 25 2018, 6:56 PM
lookandfeel/contents/runcommand/RunCommand.qml
64

You could argue KRunner is not used as a user-facing name anywhere (Setting calls it Plasma Search and Search Bar depending on where you look). Might be less confusing to just keep it at Configure...?

ngraham added inline comments.Sep 25 2018, 6:58 PM
lookandfeel/contents/runcommand/RunCommand.qml
64

Hmm, good question. Let me ask VDG.

ngraham added inline comments.Sep 25 2018, 7:10 PM
lookandfeel/contents/runcommand/RunCommand.qml
64

For now, let's just go with "Configure..." and we'll sort out the user-facing string at another time so we don't derail your patch. :)

slenz updated this revision to Diff 42319.Sep 25 2018, 7:12 PM

Remove "KRunner" from configure tooltip

ngraham accepted this revision.Sep 25 2018, 7:14 PM
This revision is now accepted and ready to land.Sep 25 2018, 7:14 PM
acrouthamel accepted this revision.Sep 25 2018, 8:41 PM

Ooh my first time being added as reviewer. ;)

Since Silas lacks commit rights (I found this out by searching on https://websvn.kde.org/trunk/kde-common/accounts?view=markup), would you like to do the honors and land this for him, @acrouthamel? Make sure the git authorship is set properly first. Land on master please since there are new strings.

Documentation is here: https://community.kde.org/Infrastructure/Phabricator#Landing_someone_else.27s_diff

This revision was automatically updated to reflect the committed changes.

would you like to do the honors and land this for him, @acrouthamel?

Yes boss... Always roping me into something new. :)