Shows tooltips for buttons left and right of the search box.
FEATURE: 398943
acrouthamel | |
ngraham |
VDG |
Shows tooltips for buttons left and right of the search box.
FEATURE: 398943
Manually test appearance of tooltips, unlikely to cause new issues.
No Linters Available |
No Unit Test Coverage |
Buildable 3207 | |
Build 3225: arc lint + arc unit |
Wow, that was fast. One minor suggestion:
lookandfeel/contents/runcommand/RunCommand.qml | ||
---|---|---|
64 | Needs ellipses; see https://hig.kde.org/style/writing/labels.html#using-ellipses-in-labels How about "Configure KRunner..." ? |
lookandfeel/contents/runcommand/RunCommand.qml | ||
---|---|---|
64 | You could argue KRunner is not used as a user-facing name anywhere (Setting calls it Plasma Search and Search Bar depending on where you look). Might be less confusing to just keep it at Configure...? |
lookandfeel/contents/runcommand/RunCommand.qml | ||
---|---|---|
64 | For now, let's just go with "Configure..." and we'll sort out the user-facing string at another time so we don't derail your patch. :) |
Since Silas lacks commit rights (I found this out by searching on https://websvn.kde.org/trunk/kde-common/accounts?view=markup), would you like to do the honors and land this for him, @acrouthamel? Make sure the git authorship is set properly first. Land on master please since there are new strings.
Documentation is here: https://community.kde.org/Infrastructure/Phabricator#Landing_someone_else.27s_diff