Differential D15642

Port "Switch Window" containment action to updated libtaskmanager API and away from KWindowSystem
ClosedPublic
Actions

Authored by hein on Sep 21 2018, 10:11 AM.

Details

Reviewers
mart
davidedmundson
Maniphest Tasks
T4457: [kwayland] Virtual Desktop protocol
Commits
R120:c64fc46955f2: Port "Switch Window" containment action to updated libtaskmanager API and away…
Summary

This makes it work on Wayland. And probably fixes bugs, the code,
especially the next/prev window stuff, was pretty wonky.

Also some general cleanup.

Depends on D13745.

Diff Detail

Repository
R120 Plasma Workspace
Branch
arcpatch-D13745
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3060
Build 3078: arc lint + arc unit
hein created this revision.Sep 21 2018, 10:11 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 21 2018, 10:11 AM
hein requested review of this revision.Sep 21 2018, 10:11 AM
davidedmundson requested changes to this revision.Oct 16 2018, 1:44 PM
davidedmundson added inline comments.
containmentactions/switchwindow/switch.cpp
203

.arg(i, desktopNames.at(i)

in case the id contains the string "%1"

(and above)

264

The old code wrapped (albeit in a weirdly coded way)

This revision now requires changes to proceed.Oct 16 2018, 1:44 PM
hein updated this revision to Diff 43752.Oct 16 2018, 7:17 PM
  • Make doSwitch wrap again
  • Don't keep the VirtualDesktopsInfo as a static member to make d_ed happy
  • Use the multi-argument arg()
davidedmundson accepted this revision.Oct 16 2018, 9:46 PM
This revision is now accepted and ready to land.Oct 16 2018, 9:46 PM
Closed by commit R120:c64fc46955f2: Port "Switch Window" containment action to updated libtaskmanager API and away… (authored by hein). · Explain WhyDec 18 2018, 7:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 42043

View Options

containmentactions/switchwindow/CMakeLists.txt

Loading...
View Options

containmentactions/switchwindow/switch.h

Loading...
View Options

containmentactions/switchwindow/switch.cpp

Loading...