Port "Switch Window" containment action to updated libtaskmanager API and away from KWindowSystem

Authored by hein on Sep 21 2018, 10:11 AM.



This makes it work on Wayland. And probably fixes bugs, the code,
especially the next/prev window stuff, was pretty wonky.

Also some general cleanup.

Depends on D13745.

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Sep 21 2018, 10:11 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 21 2018, 10:11 AM
hein requested review of this revision.Sep 21 2018, 10:11 AM
davidedmundson requested changes to this revision.Oct 16 2018, 1:44 PM
davidedmundson added inline comments.

.arg(i, desktopNames.at(i)

in case the id contains the string "%1"

(and above)


The old code wrapped (albeit in a weirdly coded way)

This revision now requires changes to proceed.Oct 16 2018, 1:44 PM
hein updated this revision to Diff 43752.Oct 16 2018, 7:17 PM
  • Make doSwitch wrap again
  • Don't keep the VirtualDesktopsInfo as a static member to make d_ed happy
  • Use the multi-argument arg()
davidedmundson accepted this revision.Oct 16 2018, 9:46 PM
This revision is now accepted and ready to land.Oct 16 2018, 9:46 PM
This revision was automatically updated to reflect the committed changes.