| dfaure | |
| ngraham |
| Baloo | |
| Frameworks |
First crash I get after enabling Dr. Konqi for slaves.
UDS_USER and UDS_GROUP are strings, not numbers, therefore I've got an assert (simplified):
"udsField & KIO::UDSEntry::UDS_NUMBER", "udsentry.cpp", line=line@entry=113)
Use the same methods to get those data as in file.
BUG:398867
Search an obvious file in $HOME, it is shown.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Fine in general, file KIO caches the username and groupname to avoud KUser having to query it every time. It also uses the uid as string if loginName is empty (if that can ever happen..?)
White at it, use fastInsert.
And this also fixes the search in the home directory :-).
The title in English :-).
I also would prefer to do the fastInsert change separately as to not clutter the diff
Copy the methods getUserName and getGroupName from kfile, those are cached, should be faster.
Keep the fastInsert for another revision.
Code looks better and I can verify that it fixes the bug. Feels a bit faster, too. Maybe wait for a final review from @broulik or someone in Frameworks though before landing.