add move to top/bottom of parent layer functionality to layer docker
Needs ReviewPublic

Authored by razvanr on Sep 17 2018, 2:09 PM.

Details

Reviewers
rempt
scottpetrovic
gdquest
timotheegiet
Group Reviewers
Krita
Summary

Just like the title mentions, the addition to the layer docker is as follows:

And the added functionality is to move the selected layers at the top/bottom of the group player in one go. This is a first pass and better ideas are welcome.

As discussed via IRC, I've included only the svg dark/light icons that appear in the above image, but the compilation fails only with this. With the png files in the source code the compilation succeeds so advice on this is needed.

note
I removed the code that enabled/disabled the move up/down layer in the layer docker as well since it really is inconsistent as it only takes in account the "active node/layer", but the operation can be performed on multiple selected layers as well. Same goes for move to top/bottom of group layer so we either have to come up with a better solution for enabling/disabling these buttons or just not use it at all.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
razvanr created this revision.Sep 17 2018, 2:09 PM
Restricted Application added a reviewer: Krita. ยท View Herald TranscriptSep 17 2018, 2:09 PM
razvanr requested review of this revision.Sep 17 2018, 2:09 PM
razvanr edited the summary of this revision. (Show Details)

Here is a version of this patch rebased against the current master (with PNG files fixed): d228719365f789045fc7ba01b4db4acd91b1d0f5

@razvanr! I'm sorry that we seem to forget about this patch. I asked painters' opinion on that, so we should get feedback soonish.

Deevad added a subscriber: Deevad.Apr 15 2019, 3:12 PM

Hi, (I'm here for opinion)

I'm not in favor of the addition of two new buttons to the layer docker as shown on the screenshot.

Mainly because I think this buttons will be pressed on rare usecase only and so it will add complexity to the GUI and possible (dangerous) misclick.

But that said, I like the idea of keeping the actions exposed to keyboard shortcuts. A GUI interaction as holding shift while pressing the up or down icon on the layer docker could work for advanced user without adding new icons.

Just for reference:

18:02 < raghukamath> dmitryK|log: it would be helpful, even there is no gui , it would be helpful to have entry in shortcuts
18:02 <@Deevad> dmitryK|log: Ok, I'll read it and reply on Phabricator
18:04 <@Deevad> dmitryK|log: raghukamath : +1 with the action existing as a shortcut. But -1 for the new buttons on the layer GUI.
18:06 < raghukamath> dmitryK|log: for shortcut it would be better to have - ctrl + shift + pgup for moving to top and ctrl + shift + pgdm to move to bottom
18:07 <@Deevad> yes, or holding shift while pressing the up or down icon
18:07 <@Deevad> something for advanced user

I am here for an opinion too. I would say yes to maybe having it in the shortcuts/right-click option when selecting multiple layers. I do not like it in the GUI though on the bottom of the layers docker.

We used to have those buttons to move layers to the very top/bottom of the stack, but we removed them as people didn't like it making the layers docker wider and was used infrequently