KSMTP: improve error handling.
ClosedPublic

Authored by dfaure on Sep 15 2018, 11:07 AM.

Details

Summary

Sending a mail to doesnotexist@example.com returns a 450 error (at least
on a Kolab server), which was wrongly displayed as "Server time out" to the
user (e.g. above the mail header, in the kmail outbox).

Now this testcase displays
"Failed to transport message. Mailbox unavailable. The server said: 4.1.1 <doesnotexit@example.com>: Recipient address rejected: User unknown in local recipient table"

It's slightly redundant, but the point is that "Mailbox unavailable" can
be translated, while the error text from the server will likely not be.

Diff Detail

Repository
R733 KSmtp
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure created this revision.Sep 15 2018, 11:07 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptSep 15 2018, 11:07 AM
Restricted Application edited subscribers, added: kde-pim; removed: KDE PIM. · View Herald Transcript
dfaure requested review of this revision.Sep 15 2018, 11:07 AM

Looks good to me, but violates the 18.08 string freeze, no?

yep string freeze

> master

dvratil accepted this revision.Sep 15 2018, 4:00 PM

Looks good, but indeed has to go to master due to string freeze.

This revision is now accepted and ready to land.Sep 15 2018, 4:00 PM
This revision was automatically updated to reflect the committed changes.

Thanks, pushed to master.