Differential D15495

Add Messages.sh
ClosedPublic
Actions

Authored by broulik on Sep 14 2018, 7:57 AM.

Details

Reviewers
davidedmundson
aacid
aspotashev
Group Reviewers
Plasma
Localization
Commits
R856:715ba3a22906: Add Messages.sh
Summary

We have translatable strings in the reminder c++ code.

BUG: 398595
FIXED-IN: 5.14.0

Test Plan

We have a StaticMessages.sh that also writes into plasma-browser-integration.pot, not sure how this works together. Else we could make a dedicated Messages.sh just for said reminder component

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 14 2018, 7:57 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 14 2018, 7:57 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sep 14 2018, 7:57 AM
broulik edited the summary of this revision. (Show Details)
davidedmundson added a comment.Sep 14 2018, 8:05 AM

According to https://websvn.kde.org/trunk/l10n-kf5/scripts/ update_translations it seems both Messages.sh and StaticMessages.sh will be invoked.

But I don't think we can use the same .pot name.

broulik updated this revision to Diff 41619.EditedSep 14 2018, 9:25 AM

Rename to plasma-browser-integration-native
I could have moved it to the reminder but I fear we will forget again should we ever use i18n in the host (which I did at one point)

ltoscano added a subscriber: ltoscano.Sep 14 2018, 9:26 AM

Correct: the names should be different, and so the domains.

broulik updated this revision to Diff 41620.Sep 14 2018, 9:27 AM

Fix typo..

aspotashev added a subscriber: aspotashev.Sep 14 2018, 9:32 AM

We already have tabsrunner/Messages.sh so adding this Messages.sh will extract the messages from tabsrunner/* twice.

broulik planned changes to this revision.Sep 14 2018, 9:32 AM

Alright, will move it to the reminder then

broulik updated this revision to Diff 41650.Sep 14 2018, 2:13 PM
  • Move Messages.sh into reminder dir
This revision is now accepted and ready to land.Sep 14 2018, 2:19 PM
Closed by commit R856:715ba3a22906: Add Messages.sh (authored by broulik). · Explain WhySep 14 2018, 2:28 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 41651