Fix Display of Ampersand in Context Menu
ClosedPublic

Authored by cordlandwehr on May 6 2016, 2:23 PM.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cordlandwehr updated this revision to Diff 3674.May 6 2016, 2:23 PM
cordlandwehr retitled this revision from to Fix Display of Ampersand in Context Menu.
cordlandwehr updated this object.
cordlandwehr edited the test plan for this revision. (Show Details)
cordlandwehr added a reviewer: kfunk.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMay 6 2016, 2:23 PM
arrowd added a subscriber: arrowd.May 6 2016, 4:34 PM

If this is intended to fix ampersand in titles of "Projects", "Filesystem", etc., then it didn't work for me.

Interesting, that works for me. A quick check: did you set LD_LIBRARY_PATH correctly so that kdevelop picks up right version of kdevplatform, not the one from system?

@Gleb are you sure that you have set correct paths such that the correct libKDevPlatformSublime.so from your build is used? You can also use "ldd" to check this.

arrowd added a comment.May 7 2016, 6:03 PM

Paths are correct it's just me using Windows. Here on Windows when using vistastyle ampersands are shown with and without this patch. I guess, it's a separate issue?

kfunk edited edge metadata.May 9 2016, 6:13 AM
In D1548#28804, @arrowdodger wrote:

Paths are correct it's just me using Windows. Here on Windows when using vistastyle ampersands are shown with and without this patch. I guess, it's a separate issue?

Different issue, but caused by similar code I think. This patch here is just for the context menus, while Gleb is talking about the dock widget titles (https://phabricator.kde.org/T1122).

Regarding this patch: Not entirely sure if this is the correct approach, my knowledge in Sublime is limited. Apol?

This patch does the same as in line 172, where the title is used for the shortcut menu. Thus, whatever is the best way to proceed, both calls should be the same IMO.

kfunk accepted this revision.May 16 2016, 9:10 PM
kfunk edited edge metadata.

-> 5.0 branch please

This revision is now accepted and ready to land.May 16 2016, 9:10 PM
This revision was automatically updated to reflect the committed changes.