Differential D15430

Open Web Shorcuts KCM from Web Shortcut Runner config
ClosedPublic
Actions

Authored by broulik on Sep 11 2018, 1:51 PM.

Details

Reviewers
leszeklesner
Group Reviewers
Plasma
VDG
Commits
R120:4b4439fe2ef5: Open Web Shorcuts KCM from Web Shortcut Runner config
Summary

The runner doesn't have any config on its own but uses the Web Shortcuts configuration.
Add a "configure" button that opens that KCM straight away.

BUG: 398242
FIXED-IN: 5.14.0

Test Plan

I don't think this was really designed to open non-krunner configuration but it's just a KCModule in a KCModuleProxy, so works just fine

  • Changed separator setting, krunner pick up that setting at runtime just fine

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Sep 11 2018, 1:51 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 11 2018, 1:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sep 11 2018, 1:51 PM
ngraham accepted this revision as: VDG.Sep 12 2018, 3:51 AM
leszeklesner accepted this revision.Sep 12 2018, 12:09 PM
This revision is now accepted and ready to land.Sep 12 2018, 12:09 PM
Closed by commit R120:4b4439fe2ef5: Open Web Shorcuts KCM from Web Shortcut Runner config (authored by broulik). · Explain WhySep 12 2018, 1:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41411

View Options

runners/webshortcuts/CMakeLists.txt

Loading...
View Options

runners/webshortcuts/plasma-runner-webshortcuts_config.desktop

Loading...