Differential D15416

Cleans up markDirty() function definition to not require parameter
ClosedPublic
Actions

Authored by utecht on Sep 11 2018, 4:47 AM.

Details

Reviewers
broulik
Commits
R166:447091a8b2a1: Cleans up markDirty() function definition to not require parameter
Summary

Remove parameters from markDirty() since they are not used or required

Diff Detail

Repository
R166 Spectacle
Branch
fixMarkDirty (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2705
Build 2723: arc lint + arc unit
utecht created this revision.Sep 11 2018, 4:47 AM
Restricted Application added a project: Spectacle. · View Herald TranscriptSep 11 2018, 4:47 AM
Restricted Application added a subscriber: Spectacle. · View Herald Transcript
utecht requested review of this revision.Sep 11 2018, 4:47 AM
broulik accepted this revision.Sep 11 2018, 6:55 AM
This revision is now accepted and ready to land.Sep 11 2018, 6:55 AM
utecht added a comment.Sep 11 2018, 12:27 PM

Am I to land this myself? I tried with arc but I got the following error:

fatal: remote error: service not enabled: /spectacle.git
ngraham added a subscriber: ngraham.Sep 11 2018, 12:31 PM

You need a contributor account to push your own changes. If you keep submitting nice patches, you should eventually apply for one! But in the meantime, I will land this for you.

P.S. thanks for using arc, that makes my life easier. Is it the same for you? Also it would be hugely helpful if you could jot down your recent impressions of KDE's new contributor process at T8711: Gathering feedback from newcomers on the current onboarding experience. Thanks!

Closed by commit R166:447091a8b2a1: Cleans up markDirty() function definition to not require parameter (authored by utecht, committed by ngraham). · Explain WhySep 11 2018, 12:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41376

View Options

src/Gui/SettingsDialog/GeneralOptionsPage.h

Loading...
View Options

src/Gui/SettingsDialog/GeneralOptionsPage.cpp

Loading...