When there is only one thumbnail it is painted larger. This pixmap is always generated, even if we ended up creating more than one thumbnail.
This patch makes it remember the first valid thumbnail and paints the larger pixmap only as needed.
Details
Details
- Reviewers
ngraham - Group Reviewers
Dolphin - Commits
- R320:44f2852fb299: [Thumbnails] Paint larger "one thumbnail" tile only when needed
Thumbnails of folders with no, one, or multiple previews are still rendered correctly.
Saves up to 1 second generating the thumbnails here, however, I didn't really notice a huge impact in real world testing
Diff Detail
Diff Detail
- Repository
- R320 KIO Extras
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Seems fine to me. Code looks sane and behavior appears to be unchanged. Maybe faster, but that might just be confirmation bias talking. :)