When a job is repeating, it is expected that its start time would be further in the past than the normal lead time, because it is repeating.
Therefore the evaluation of such a job when it repeats must not lead to an abort.
Details
Use "repeated_scheduler_job_no_twilight_30s_leadtime.esl", Copy "3x30s_Red.esq" to "/tmp/kstars_tests".
Change the lead time to 0,5 minutes in the Ekos settings, so that a full batch is longer than the lead time.
There are 7 batches of the single target in the schedule. Run the Scheduler, observe as the first batch finishes.
Without the change, when a job repeat, a message is logged that that job is aborted, and that job is re-evaluated to restart.
With the change, when a job repeats, no message is logged, and that job repeats without state change.
Diff Detail
- Repository
- R321 KStars
- Branch
- bugfix__repeated_job_aborting (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 2697 Build 2715: arc lint + arc unit
Could you please be a little more specific with the test case? I cannot reproduce it yet.
@wreissenberger Tell me what you think. Next fix on my list is a regression on scheduler jobs approaching dawn being restarted indefinitely, no easy test for now...
I’ve seen the messages in my own logfile last night. I ca Test it late this afternoon.
Ok, checked. I could reproduce it on master and with the patch the message disappeared.