Fixes a regression introduced by not using the selected state.
The views other than icon view actually do have a proper highlighted background
Details
Details
- Reviewers
fvogt - Group Reviewers
Dolphin VDG - Commits
- R318:c5ce845e83d3: Do use QIcon::Selected for non-icon view
Fixes Places panel icons not turning white when selected
Before
After
Icon view still fine
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks good in isolation. However all this song-and-dance makes me feel like we should just draw a background around the whole icon and text in Dolphin like we do for the file dialog and Folder View. That would be consistent and not require a ton of workarounds for monochrome icons. Thoughts?
Comment Actions
This is unrelated to this patch, which is in stable branch where we can't do huge changes.