Differential D15353

Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX
ClosedPublic
Actions

Authored by zzag on Sep 8 2018, 4:43 PM.

Details

Reviewers
romangg
Group Reviewers
KWin
Commits
R278:9658d727bdae: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX
Summary

The EWMH spec doesn't have the _NET_WM_WINDOW_TYPE_COMBOBOX atom. Instead,
it has _NET_WM_WINDOW_TYPE_COMBO.

In addition to that, Qt sets _NET_WM_WINDOW_TYPE_COMBO on combo box popups.

https://standards.freedesktop.org/wm-spec/wm-spec-latest.html

Diff Detail

Repository
R278 KWindowSystem
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Sep 8 2018, 4:43 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 8 2018, 4:43 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
zzag requested review of this revision.Sep 8 2018, 4:43 PM
aacid added a subscriber: aacid.Sep 9 2018, 6:36 PM

I'm not a KWindowSystem developer so take this with a grain of salt, but maybe it makes sense to still support the old name in case someone is really using it and add the new one as a synonym?

zzag added a comment.EditedSep 9 2018, 7:10 PM
In D15353#322991, @aacid wrote:

I'm not a KWindowSystem developer so take this with a grain of salt, but maybe it makes sense to still support the old name in case someone is really using it and add the new one as a synonym?

Well, no, _NET_WM_WINDOW_TYPE_COMBOBOX is a KWindowSystem's specific implementation thing/typo, it's not used widely. GTK+ and Qt set _NET_WM_WINDOW_TYPE_COMBO. So, I think we shouldn't add a new synonym.

romangg added a subscriber: romangg.Sep 21 2018, 11:30 AM
In D15353#323028, @zzag wrote:
In D15353#322991, @aacid wrote:

I'm not a KWindowSystem developer so take this with a grain of salt, but maybe it makes sense to still support the old name in case someone is really using it and add the new one as a synonym?

Well, no, _NET_WM_WINDOW_TYPE_COMBOBOX is a KWindowSystem's specific implementation thing/typo, it's not used widely. GTK+ and Qt set _NET_WM_WINDOW_TYPE_COMBO. So, I think we shouldn't add a new synonym.

So this warrants a change to KWindowSystem as well?

zzag added a comment.Sep 21 2018, 11:37 AM
In D15353#329424, @romangg wrote:

... to KWindowSystem as well?

Isn't it KWindowSystem repo? (maybe, I don't understand your question)

romangg added a comment.Sep 21 2018, 11:54 AM

Whoops, yea. My fault. I think it's fine to replace the name, since Qt/GTK use the correct one and normally apps use these libs instead of setting such properties directly.

zzag added a comment.Sep 21 2018, 4:26 PM
In D15353#329431, @romangg wrote:

Whoops, yea. My fault. I think it's fine to replace the name, since Qt/GTK use the correct one and normally apps use these libs instead of setting such properties directly.

Can it go in?

romangg accepted this revision.Oct 1 2018, 5:43 PM
This revision is now accepted and ready to land.Oct 1 2018, 5:43 PM
Closed by commit R278:9658d727bdae: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX (authored by zzag). · Explain WhyOct 2 2018, 5:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 42741

View Options

autotests/netwininfotestclient.cpp

Loading...
View Options

src/platforms/xcb/atoms_p.h

Loading...
View Options

src/platforms/xcb/netwm.cpp

Loading...