Differential D15332

Use the more common string "Edit" in place of "Change"
ClosedPublic
Actions

Authored by ngraham on Sep 7 2018, 2:26 PM.

Details

Reviewers
broulik
Group Reviewers
Dolphin
VDG
Commits
R824:f2f313f4e306: Use the more common string "Edit" in place of "Change"
Summary

"Edit" is a more common string than "Change", so let's use that instead.

BUG: 398309
FIXED-IN: 18.12.0

Test Plan

Diff Detail

Repository
R824 Baloo Widgets
Branch
edit-instead-of-change (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2589
Build 2607: arc lint + arc unit
ngraham created this revision.Sep 7 2018, 2:26 PM
Restricted Application added a project: Baloo. · View Herald TranscriptSep 7 2018, 2:26 PM
Restricted Application added a subscriber: Baloo. · View Herald Transcript
ngraham requested review of this revision.Sep 7 2018, 2:26 PM
ngraham edited the test plan for this revision. (Show Details)Sep 7 2018, 2:28 PM
broulik added a subscriber: broulik.Sep 7 2018, 2:34 PM

The window title for the tag editor should also be changed from "Change Tags" to "Edit Tags"

bruns added a subscriber: bruns.Sep 7 2018, 6:37 PM

As @broulik said, otherwise +1

ngraham updated this revision to Diff 41184.Sep 7 2018, 10:27 PM

Also change dialog titles

broulik accepted this revision.Sep 8 2018, 9:47 AM
This revision is now accepted and ready to land.Sep 8 2018, 9:47 AM
ngraham closed this revision.Sep 9 2018, 4:23 AM

Revision Contents
Changeset List

PathPackages
Msrc/kcommentwidget.cpp (6 lines)
Msrc/kedittagsdialog.cpp (2 lines)
Msrc/tagwidget.cpp (2 lines)

Diff 41184

View Options

src/kcommentwidget.cpp

Loading...
View Options

src/kedittagsdialog.cpp

Loading...
View Options

src/tagwidget.cpp

Loading...