Don't use QIcon::Selected state for selected icon
ClosedPublic

Authored by broulik on Sep 3 2018, 9:45 PM.

Details

Summary

This causes selected monochrome Breeze icons to turn white as this state is meant for when the icon is actually painted ontop of e.g. a blue highlighted bar.
Since the advanced icon configuration (where you could choose a custom hint color and other effects) has been removed in Plasma 5.13 and more importantly the fact that Dolphin always tints the icon in the highlight color disregarding any custom icon effects settings this is an acceptable change.

BUG: 398014

Test Plan

Changed icon size to 16px, selected a folder, folder icon was still there. You can hardly see the blue tinting with the 1px outline icons, though
Before


After

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 3 2018, 9:45 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptSep 3 2018, 9:45 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
broulik requested review of this revision.Sep 3 2018, 9:45 PM
ngraham accepted this revision.Sep 3 2018, 9:58 PM
ngraham added a subscriber: ngraham.

Fixes 398014. Could we land this on the stable branch?

This revision is now accepted and ready to land.Sep 3 2018, 9:58 PM
ngraham edited the summary of this revision. (Show Details)Sep 3 2018, 9:58 PM
fvogt accepted this revision.Sep 4 2018, 6:55 AM

I tried it - except for the not anymore disappearing icons I can't spot any difference.

This revision was automatically updated to reflect the committed changes.