No need to carry the weight of that extra float all the way down or to
depend on it in GridMesh. I suspect even the FileLoader doesn't need it
since in every point of use I found so far w is just dropped.
Details
Details
Diff Detail
Diff Detail
- Repository
- R231 Atelier
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I was able to apply this but it is not based on master and should be rebased.
| src/widgets/3dview/linemesh.cpp | ||
|---|---|---|
| 63 | This is not our style std::transform(pos.cbegin(), pos.cend(), std::back_inserter(vertices), [] (const QVector4D &x) {
return x.toVector3D();
}); | |
| src/widgets/3dview/linemesh.cpp | ||
|---|---|---|
| 63 | this is the style for stl - with c++ moving to c++20 I have no problem with it (I actually prefer some of that) | |