Differential D15021

Workaround bug with native rendering and opacity in TextField text
ClosedPublic
Actions

Authored by davidedmundson on Aug 23 2018, 12:03 PM.

Details

Reviewers

broulik

Group Reviewers

Plasma

Commits

R242:2faa71a55a75: Workaround bug with native rendering and opacity in TextField text

Summary

Problem is identified in https://bugreports.qt.io/browse/QTBUG-70138
with a potential patch for upstream.

With native rendering the alpha is pointlessly also set in the
glBlendFunc despite also being used in the uniform of the shader.
Resulting in a visual bug when used on a window with alpha (such as
Dialog)

It sucks, but we were starting to see people work round it by copying
more invasive workarounds everywhere else which I want to avoid.

BUG: 396813

Test Plan

Looked at a text field

Diff Detail

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson created this revision.Aug 23 2018, 12:03 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptAug 23 2018, 12:03 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

davidedmundson requested review of this revision.Aug 23 2018, 12:03 PM

Harbormaster completed remote builds in B2152: Diff 40297.Aug 23 2018, 12:03 PM

broulik accepted this revision.Aug 23 2018, 12:47 PM

This revision is now accepted and ready to land.Aug 23 2018, 12:47 PM

We could also get rid of the import QtQuick.Window 2.2 line since it only existed to get Screen.devicePixelRatio, which this patch removes.

And potentially QtQuickControlsPrivate import but I recall it had some sideeffects that we needed, despite not using anything from it(?)

Anyway, confirmed that this works around the problem for me. +1

ngraham mentioned this in D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button.Aug 23 2018, 1:01 PM

ngraham mentioned this in D15011: [Kickoff] Make the search field always look like a search field.Aug 23 2018, 3:05 PM

Closed by commit R242:2faa71a55a75: Workaround bug with native rendering and opacity in TextField text (authored by davidedmundson). · Explain WhyAug 28 2018, 9:30 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/declarativeimports/plasmastyle/TextFieldStyle.qml (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	40297	a0ab02c		Aug 23 2018, 12:03 PM	★	★
Diff 2	40542	40b6550	R242:2faa71a55a750d54c941aa6dd73ec02cfc9be34b	Aug 28 2018, 9:26 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
d2eff2daa096	d0c5cba05e97	a0ab02c05205	David Edmundson	Workaround bug with native rendering and opacity in TextField text (Show More…)	Aug 23 2018, 12:01 PM

Diff 40542

View Options

src/declarativeimports/plasmastyle/TextFieldStyle.qml