Add example based on https://techbase.kde.org/Development/Tutorials/KWallet so that it can be kept up-to-date. The techbase tutoriel can be archived and not maintained anymore.
Details
Details
- Reviewers
valir dfaure - Group Reviewers
Frameworks - Commits
- R311:87a84ac866c5: Move example from techbase to own repo
It compiles
Diff Detail
Diff Detail
- Repository
- R311 KWallet
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 2030 Build 2048: arc lint + arc unit
Comment Actions
I'm not sure to understand: it *can* be compiled, whereas on the current status (in the wiki) it will never be ! Maybe the next step would be to add a trigger from the make test command?
Comment Actions
It can be compiled, but it is not.
So it will rot, we've had lots of cases of this, if the code is not compiled every single time on the CI, it will eventually not compile.
Comment Actions
Yes this needs to be compiled so it doesn't rot.
The solution is obviously not add_subdirectory since that wouldn't catch missing find_packages etc.
One way is to have cmake run cmake, like ki18n/autotests/CMakeLists.txt does to run cmake on the ki18n_install subdir.
Comment Actions
And yes this needs a license, obviously. If the original author(s) can't be reached anymore, that means rewriting the example :(
| examples/asynchronous_app/CMakeLists.txt | ||
|---|---|---|
| 3 | CONFIG looks less negative than the old "NO_MODULE" | |
| examples/asynchronous_app/dialog.cpp | ||
| 33 | Urgh, better have a QVBoxLayout* local variable. | |
| 41 | new-style connect would be better | |
| examples/asynchronous_app/dialog.h | ||
| 16 | nullptr | |
Comment Actions
Added Licence, made it compile within the whole project and fix issues raised by dfaure.
I think we shouldn't care about making the example self-standing. It's aimed at tutoring people to use the lib, not ECM nor CMake