When /home is a symlink, for instance (as is often the case on FreeBSD),
group deletion would fail because KConfig was comparing non-canonical
paths with canonical-paths:
QDEBUG : KConfigTest::testDelete() Comparing "/home/adridg/.qttest/config/
kconfigtest_subdir/kconfigtest" and "/usr/home/adridg/.qttest/config/
kconfigtest_subdir/kconfigtest"
mkdir /tmp/derp; ln -s /tmp/derp /tmp/drop
HOME=/tmp/derp bin/kconfigtest testDelete # Success
HOME=/tmp/drop bin/kconfigtest testDelete # Fail
| No Linters Available |
| No Unit Test Coverage |
| Buildable 6715 | |
| Build 6733: arc lint + arc unit |
This shows up in the unit tests. Whether it has any effect in real life is unknown. FreeBSD often -- sometimes, maybe, depending on FS setup and layout -- has /home -> /usr/home or /home -> usr/home, and of course there could be weird user setups as well where .cache is symlinked to a different location with more disk space. In any case, this is triggering unit-test failures in the CI, so cleaning it up to consistently compare the same kind of filename is a good thing. I'll give this a test on my home system and give a shout when I have.
Totals: 44 passed, 2 failed, 0 skipped, 0 blacklisted, 225ms
The two failed tests are:
Totals: 45 passed, 1 failed, 0 skipped, 0 blacklisted, 229ms
The one failed test is:
Some tests means run HOME=/tmp/drop bin/kconfigtest testDelete testThreads testDefaults
********* Start testing of KConfigTest *********
Config: Using QtTest library 5.10.1, Qt 5.10.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 5.0.0 (tags/RELEASE_500/final 312559))
PASS : KConfigTest::initTestCase()
FAIL! : KConfigTest::testDelete() '!delgr.exists()' returned FALSE. ()
Loc: [/home/adridg/src/kde/tier-1/kconfig/autotests/kconfigtest.cpp(802)]
PASS : KConfigTest::testThreads()
FAIL! : KConfigTest::testDefaults() Compared values are not the same
Actual (group.readEntry("entry1", QString())): "hello"
Expected (Default) : "Default"
Loc: [/home/adridg/src/kde/tier-1/kconfig/autotests/kconfigtest.cpp(399)]
PASS : KConfigTest::cleanupTestCase()********* Start testing of KConfigTest *********
Config: Using QtTest library 5.10.1, Qt 5.10.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 5.0.0 (tags/RELEASE_500/final 312559))
PASS : KConfigTest::initTestCase()
PASS : KConfigTest::testDelete()
FAIL! : KConfigTest::testThreads() Compared values are not the same
Actual (group.readEntry("entry1", QString())): "hello"
Expected (Default) : "Default"
Loc: [/zbigone/src/kde/tier-1/kconfig/autotests/kconfigtest.cpp(399)]
PASS : KConfigTest::testDefaults()
PASS : KConfigTest::cleanupTestCase()
Totals: 4 passed, 1 failed, 0 skipped, 0 blacklisted, 41ms
********* Finished testing of KConfigTest *********Sorry, this is getting very confusing:
I suspect there are some more missing canonicalizations, but I don't have time right now to go hunting them.
https://build.kde.org/job/Frameworks/view/Everything/job/kconfig/job/kf5-qt5%20FreeBSDQt5.12/ green !!! :-)
Well, blue, because blue is the new green (!?).