Hide more implementation details and make InlineNote more extensible.
Details
Details
- Reviewers
cullmann - Commits
- R39:4e279cd72493: InlineNote: Pimpl inline note data without allocs
make && make test
Diff Detail
Diff Detail
- Repository
- R39 KTextEditor
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I think that is ok, but one should remove column(), isValid() and == (which is no equal anyways ATM).
Comment Actions
Looks ok to me, except one thing: the operator== is used to compare a note from the list to the "currently active" note in the view. If this compares also the "under mouse" state, this code might be broken now ...?