Differential D14860

Make middle click closes tab optional
Needs ReviewPublic
Actions

Authored by carlavilla on Aug 15 2018, 1:16 PM.

Details

Reviewers
hein
ngraham
Summary

BUG: 396357

Created an option in yakuake configuration to prevent closing a tab accidentally with the middle button of the mouse.

Test Plan

Tested on Arch Linux with Plasma 5.12 and Qt 5.11.1

  • I check 'Prevent close tab with mouse middle button' and tried to close a tab with the middle button. The tab not closes.
  • I uncheck 'Prevent close tab with mouse middle button' and tried to close a tab with the middle button. The tab closes.

Diff Detail

Repository
R369 Yakuake
Lint
Lint Skipped
Unit
Unit Tests Skipped
carlavilla requested review of this revision.Aug 15 2018, 1:16 PM
carlavilla created this revision.
carlavilla created this object with edit policy "Administrators".
cfeck added a subscriber: cfeck.Aug 15 2018, 2:26 PM

I think we say "middle mouse button", not "mouse middle button".

ngraham resigned from this revision.Aug 15 2018, 6:28 PM
In D14860#309590, @cfeck wrote:

I think we say "middle mouse button", not "mouse middle button".

We do indeed. :)

Not being a user of Yakuake, mice with middle buttons, or my touchpad's virtual middle button I'm afraid I don't feel informed enough to pass judgment on whether or not this is a good idea.

carlavilla updated this revision to Diff 39810.Aug 15 2018, 8:59 PM

Change 'mouse middle button' to 'middle mouse button'

carlavilla added a comment.Aug 15 2018, 9:00 PM
In D14860#309590, @cfeck wrote:

I think we say "middle mouse button", not "mouse middle button".

Thanks, I update the patch

hein added a comment.Aug 16 2018, 10:14 AM

Hi,

thanks for your patch.

Please make the option positive, not negative. So, make it "Middle-click to close tabs" and enable it by default. Then the user can disable it if they prefer. The Task Manager settings in Plasma also use "middle-click", so the wording is good for consistency.

carlavilla updated this revision to Diff 39875.Aug 16 2018, 6:49 PM
In D14860#310027, @hein wrote:

Hi,

thanks for your patch.

Please make the option positive, not negative. So, make it "Middle-click to close tabs" and enable it by default. Then the user can disable it if they prefer. The Task Manager settings in Plasma also use "middle-click", so the wording is good for consistency.

I made the changes

andrewfhou added a subscriber: andrewfhou.Feb 29 2020, 7:34 PM

Patch looks good - option language and behavior all feels natural. Being so old, the patch is using a deprecated location for "yakuake.knsrc", so that will need to be changed

Revision Contents
Changeset List

PathPackages
Mapp/config/windowsettings.ui (58 lines)
Mapp/config/yakuake.kcfg (5 lines)
Mapp/tabbar.cpp (2 lines)

Diff 39875

View Options

app/config/windowsettings.ui

Loading...
View Options

app/config/yakuake.kcfg

Loading...
View Options

app/tabbar.cpp

Loading...