Differential D14843

[Activities Linking] Don't offer for non-local URLs
ClosedPublic
Actions

Authored by broulik on Aug 14 2018, 3:41 PM.

Details

Reviewers
davidedmundson
dfaure
ivan
Commits
R320:1e44637d0315: [Activities Linking] Don't offer for non-local URLs
Summary

It does toLocalPath() when adding the action, so it doesn't work for non-local ones and so there's no point in offering a defunct context menu entry

Test Plan
  • Linking single and multiple local files still works
  • Linking files on desktop:/ still works
  • Entry no longer shows up for desktop:/ itself as it cannot add that anyway

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik requested review of this revision.Aug 14 2018, 3:41 PM
broulik created this revision.
ivan accepted this revision.Aug 15 2018, 2:22 PM

Ok, though a better approach IMO would be to fix linking the non-local URLs :)

Push it, and if somebody complains, we can revise the decision.

This revision is now accepted and ready to land.Aug 15 2018, 2:22 PM
Closed by commit R320:1e44637d0315: [Activities Linking] Don't offer for non-local URLs (authored by broulik). · Explain WhyAug 16 2018, 9:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39841

View Options

activities/fileitemplugin/FileItemLinkingPlugin.cpp

Loading...
View Options

activities/fileitemplugin/FileItemLinkingPlugin_p.h

Loading...