Include ECMEnableSanitizers as expected by KDE CI
AbandonedPublic

Authored by kossebau on Apr 25 2016, 8:26 AM.

Details

Reviewers
nienhueser
rahn
Summary

Tests on KDE CI currently all fail because the CI currently has been setup
to somehow expect ECMEnableSanitizers.cmake being included with any project
and thus being instructable to use ASAN. If not possible, things fail
somehow.
While that possibly should be sorted out to not being enforced,
having ASAN being used at least with the KDE CI should improve Marble's code
checking.
Including ECMEnableSanitizers.cmake should not have any sideeffects,
unless ECM_ENABLE_SANITIZERS is set.
See http://api.kde.org/ecm/module/ECMEnableSanitizers.html

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
kossebau updated this revision to Diff 3504.Apr 25 2016, 8:26 AM
kossebau retitled this revision from to Include ECMEnableSanitizers as expected by KDE CI.
kossebau updated this object.
kossebau edited the test plan for this revision. (Show Details)
kossebau added reviewers: rahn, nienhueser.
kossebau updated this revision to Diff 3749.May 10 2016, 4:00 PM
kossebau removed R34 Marble as the repository for this revision.

Update to latest master

kossebau set the repository for this revision to R34 Marble.May 10 2016, 4:03 PM
mayamadam accepted this revision.May 13 2016, 2:30 PM
mayamadam added a reviewer: mayamadam.
mayamadam added a subscriber: mayamadam.
This comment was removed by bcooksley.
This revision is now accepted and ready to land.May 13 2016, 2:30 PM
kossebau removed a subscriber: mayamadam.
This revision now requires review to proceed.May 13 2016, 4:33 PM
bcooksley removed a subscriber: bcooksley.
kossebau abandoned this revision.Jul 28 2016, 11:06 PM

CI for now got a custom solution to inject ASAN when running the Marble tests
(And Marble is just one example of possibly more non-ECM using KDE projects, so another solution is needed in general)