Differential D14806

[AppStream Runner] Reduce verbosity of log output
ClosedPublic
Actions

Authored by bruns on Aug 13 2018, 7:59 PM.

Details

Reviewers
ngraham
davidedmundson
Group Reviewers
Plasma
Commits
R120:8d945c2e5547: [AppStream Runner] Reduce verbosity of log output
Summary

Its rather pointless to spew an error message each time a query is done.
Output the warning message just once (on the default logging level), and
output further messages only at debug level.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Aug 13 2018, 7:59 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 13 2018, 7:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bruns requested review of this revision.Aug 13 2018, 7:59 PM
apol accepted this revision.Aug 15 2018, 10:06 AM
apol added a subscriber: apol.

LGTM, maybe commit once only? xD

This revision is now accepted and ready to land.Aug 15 2018, 10:06 AM
apol requested changes to this revision.Aug 15 2018, 10:07 AM

Please squash all changes

This revision now requires changes to proceed.Aug 15 2018, 10:07 AM
bruns requested review of this revision.Aug 22 2018, 1:03 PM
bruns added a reviewer: ngraham.

Why should I squash the commits? Each one:

  • compiles and works on its own
  • addresses a slightly different issue

Citing from https://community.kde.org/Policies/Commit_Policy#Commit_complete_changesets

OTOH, commits should be preferably "atomic" - not splittable. That means that every bugfix, feature, refactoring or reformatting should go into an own commit. This, too, improves the readability of the history.

apol added a comment.Aug 28 2018, 10:34 AM

Because your commits change all very closely related things and even fix each other.

bruns added a comment.Aug 31 2018, 1:12 PM
In D14806#316424, @apol wrote:

Because your commits change all very closely related things and even fix each other.

first yes, second no.

bruns updated this revision to Diff 40774.Aug 31 2018, 2:30 PM

rebase after D14807

bruns added a comment.Sep 2 2018, 6:54 PM

Would be nice to get this in soon, the current state logs a message everytime you type a character in KRunner.

bruns added a comment.Sep 13 2018, 11:42 AM

@apol Still waiting for review ...

davidedmundson accepted this revision.Sep 13 2018, 11:57 AM
bruns removed a reviewer: apol.Sep 13 2018, 12:33 PM
This revision is now accepted and ready to land.Sep 13 2018, 12:33 PM
Closed by commit R120:8d945c2e5547: [AppStream Runner] Reduce verbosity of log output (authored by bruns). · Explain WhySep 13 2018, 12:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41542

View Options

runners/appstream/appstreamrunner.cpp

Loading...