Add bool Definition::foldingEnabled() const
ClosedPublic
Actions

Authored by dhaumann on Aug 13 2018, 4:42 PM.

Details

Reviewers

cullmann
vkrause

Commits

R216:de651c8cb6b3: Add bool Definition::foldingEnabled() const

Summary

foldingEnabled() returns true, if either indentationbased folding
or folding via folding regions are defined. This is required for
showing/hiding the code folding region in KTextEditor.

Test Plan

make && make test

Diff Detail

Repository

R216 Syntax Highlighting

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dhaumann created this revision.Aug 13 2018, 4:42 PM

Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptAug 13 2018, 4:42 PM

Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript

dhaumann requested review of this revision.Aug 13 2018, 4:42 PM

Harbormaster completed remote builds in B1785: Diff 39621.Aug 13 2018, 4:42 PM

Add another test, now all code paths are tested

Harbormaster completed remote builds in B1786: Diff 39622.Aug 13 2018, 4:47 PM

IMHO makes sense and one of the last missing pieces for KTextEditor.

This revision is now accepted and ready to land.Aug 13 2018, 6:58 PM

Closed by commit R216:de651c8cb6b3: Add bool Definition::foldingEnabled() const (authored by dhaumann). · Explain WhyAug 13 2018, 7:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/syntaxrepository_test.cpp (34 lines)
M			src/lib/definition.h (9 lines)
M			src/lib/definition.cpp (19 lines)
M			src/lib/definition_p.h (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	39621	42259b6		Aug 13 2018, 4:42 PM	★	★
Diff 2	39622	42259b6	- Add another test, now all code paths are tested	Aug 13 2018, 4:47 PM	★	★
Diff 3	39632	0b8d8ac	R216:de651c8cb6b34bbe6bf75707769ecaeae8e97582	Aug 13 2018, 7:10 PM	★	★