Differential D14799

Add bool Definition::foldingEnabled() const
ClosedPublic
Actions

Authored by dhaumann on Aug 13 2018, 4:42 PM.

Details

Reviewers
cullmann
vkrause
Commits
R216:de651c8cb6b3: Add bool Definition::foldingEnabled() const
Summary

foldingEnabled() returns true, if either indentationbased folding
or folding via folding regions are defined. This is required for
showing/hiding the code folding region in KTextEditor.

Test Plan

make && make test

Diff Detail

Repository
R216 Syntax Highlighting
Branch
expose-folding-enabled (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1786
Build 1804: arc lint + arc unit
dhaumann created this revision.Aug 13 2018, 4:42 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptAug 13 2018, 4:42 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
dhaumann requested review of this revision.Aug 13 2018, 4:42 PM
dhaumann updated this revision to Diff 39622.Aug 13 2018, 4:47 PM
  • Add another test, now all code paths are tested
cullmann accepted this revision.Aug 13 2018, 6:58 PM

IMHO makes sense and one of the last missing pieces for KTextEditor.

This revision is now accepted and ready to land.Aug 13 2018, 6:58 PM
Closed by commit R216:de651c8cb6b3: Add bool Definition::foldingEnabled() const (authored by dhaumann). · Explain WhyAug 13 2018, 7:11 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Mautotests/syntaxrepository_test.cpp (34 lines)

Diff 39622

View Options

autotests/syntaxrepository_test.cpp

Loading...