| kossebau | |
| dfaure |
It is too primitive and simple for anything but the absolutely most basic things
It is fixed to FixedStrings, search in all columns and caseinsensitive. And it seems to
not really be fixeable. So just mark it as deprecated and remove it at a later point.
It has approximately 6 users across the kde codebase, let's fix them one by one.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
+1, and also too narrow regarding being specific to QLineEdit and QSFPM. If at all this should be just the logic, and be independent of the UI.
This class was doing it with a timer, I wonder if that should be part of the recommendation ("use QLineEdit with a timer"), or if we don't recommend delaying the searching as a general solution.
(e.g. another typical fix for the "I type one letter and the result is huge" issue is to require 3 letters).
| src/kfilterproxysearchline.h | ||
|---|---|---|
| 48 | Why not KITEMVIEWS_DEPRECATED_EXPORT? While being defined as KITEMVIEWS_EXPORT KITEMVIEWS_DEPRECATED, so effectively the same, I wonder about consistent usage of the macros, and if there is areason not to use this special one? | |