Differential D14668

[KCM GridDelegate] Use layer effect only on OpenGL backend
ClosedPublic
Actions

Authored by broulik on Aug 7 2018, 9:29 AM.

Details

Reviewers
mart
davidedmundson
Group Reviewers
Plasma
Commits
R296:94c6f3152188: [KCM GridDelegate] Use layer effect only on OpenGL backend
Summary

QtGraphicalEffects only works then, otherwise we render no thumbnail whatsoever

CCBUG: 397220

Test Plan

Ran QT_QUICK_BACKEND=software systemsettings5 I can now see the grid delegates again, albeit with no shadow or border around it

CMakeLists.txt for kdeclarative says Qt 5.8 minimum which is where the GraphicsInfo API was introduced

Diff Detail

Repository
R296 KDeclarative
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Aug 7 2018, 9:29 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 7 2018, 9:29 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Aug 7 2018, 9:29 AM
broulik edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Aug 7 2018, 1:03 PM
This revision is now accepted and ready to land.Aug 7 2018, 1:03 PM

Revision Contents
Changeset List

Diff 39244

View Options

src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

Loading...