Differential D14609

Do not return reference
ClosedPublic
Actions

Authored by shubham on Aug 4 2018, 5:52 PM.

Details

Reviewers
ngraham
cfeck
broulik
Commits
R241:65f56f12aa7f: Do not return reference
Summary

Do not return a reference in private API

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
shubham created this revision.Aug 4 2018, 5:52 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 4 2018, 5:52 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
shubham requested review of this revision.Aug 4 2018, 5:52 PM
shubham edited the summary of this revision. (Show Details)Aug 4 2018, 5:58 PM
broulik added a subscriber: broulik.Aug 4 2018, 9:11 PM

Also remove the const?

shubham updated this revision to Diff 39097.Aug 5 2018, 3:17 AM

Remove const

cfeck accepted this revision.Aug 5 2018, 3:33 AM
This revision is now accepted and ready to land.Aug 5 2018, 3:33 AM
shubham added a comment.Aug 5 2018, 3:49 AM
This comment was removed by shubham.
Closed by commit R241:65f56f12aa7f: Do not return reference (authored by shubham). · Explain WhyAug 5 2018, 4:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39099

View Options

src/filewidgets/kfileplaceeditdialog.cpp

Loading...
View Options

src/filewidgets/kfileplaceeditdialog_p.h

Loading...