Home
Phabricator
Search
Log In
Differential
D14609
Do not return reference
Closed
Public
Actions
Authored by
shubham
on Aug 4 2018, 5:52 PM.
Edit Revision
Update Diff
Download Raw Diff
Edit Related Revisions...
Edit Parent Revisions
Edit Child Revisions
Edit Related Objects...
Edit Commits
Edit Tasks
Subscribe
Mute Notifications
Award Token
Flag For Later
Tags
Frameworks
Subscribers
broulik
,
kde-frameworks-devel
Details
Reviewers
ngraham
cfeck
broulik
Commits
R241:65f56f12aa7f: Do not return reference
Summary
Do not return a reference in private API
Diff Detail
Left (Diff 39078)
Right (Diff 39097)
Repository
R241 KIO
Lint
Lint Skipped
Unit
Unit Tests Skipped
Repository
R241 KIO
Lint
Lint Skipped
Unit
Unit Tests Skipped
shubham
created this revision.
Aug 4 2018, 5:52 PM
Restricted Application
added a project:
Frameworks
.
·
View Herald Transcript
Aug 4 2018, 5:52 PM
Restricted Application
added a subscriber:
kde-frameworks-devel
.
·
View Herald Transcript
shubham
requested review of this revision.
Aug 4 2018, 5:52 PM
shubham
edited the summary of this revision.
(Show Details)
Aug 4 2018, 5:58 PM
broulik
added a subscriber:
broulik
.
Aug 4 2018, 9:11 PM
Comment Actions
Also remove the
const
?
shubham
updated this revision to
Diff 39097
.
Aug 5 2018, 3:17 AM
Comment Actions
Remove
cons
t
shubham
added a reviewer:
broulik
.
Aug 5 2018, 3:18 AM
cfeck
accepted this revision.
Aug 5 2018, 3:33 AM
This revision is now accepted and ready to land.
Aug 5 2018, 3:33 AM
shubham
added a comment.
Aug 5 2018, 3:49 AM
This comment was removed by
shubham
.
Closed by commit
R241:65f56f12aa7f: Do not return reference
(authored by
shubham
).
·
Explain Why
Aug 5 2018, 4:40 AM
This revision was automatically updated to reflect the committed changes.