Allows ringing devices from KRunner
Details
Details
- Reviewers
broulik davidedmundson apol - Group Reviewers
KDE Connect Plasma - Commits
- R224:e298b73f8ec6: Find my phone runner
R224:aec37877a211: Find my phone runner
Enter find, ring, or device name, activate entry
Diff Detail
Diff Detail
- Repository
- R224 KDE Connect
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| runners/findmyphone/findmyphonerunner.cpp | ||
|---|---|---|
| 62 | That would only work if these were ANDs instead of ORs. If we find "Ring" in the query we still needs the device names to build the results | |
| runners/findmyphone/findmyphonerunner.cpp | ||
|---|---|---|
| 47 ↗ | (On Diff #45073) | Can we make this non-blocking? it's not fun when krunner blocks, especially at search. |
Comment Actions
It looks like this patch has a dependency on another one. In my version of the repository, I don't have runners/CMakeLists.txt so this patch doesn't apply, and there is no reference to add_subdirectory(runners) in the top-level CMakeLists
Probably a problem fixed by the same solution: When I try to build, I get the error:
"CMake Error at runners/findmyphone/CMakeLists.txt:3 (add_library):
Target "krunner_kdeconnect_findmyphone" links to target "KF5::Runner" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing?"
| runners/findmyphone/findmyphonerunner.cpp | ||
|---|---|---|
| 47 ↗ | (On Diff #45073) | @nicolasfella In case you don't know where to look, here is an example of how to use QDbusPendingReply: https://cgit.kde.org/kdeconnect-kde.git/tree/smsapp/conversationlistmodel.cpp#n82 |