It can be useful in itself and when porting code from Plasma.
Diff Detail
Diff Detail
- Repository
- R169 Kirigami
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 23018 Build 23036: arc lint + arc unit
Comment Actions
good idea, 2 comments:
- the import version of platformtheme cannot change or will break existing code
- needs a smallestfont declared also in all version of qml-base theme implementations, one in controls, one is in the kirigami repo, under controls, one is in the plasma-framework repo, under src/declarativeimports/kirigamiplasmastyle/
| src/kirigamiplugin.cpp | ||
|---|---|---|
| 173 ↗ | (On Diff #38964) | this will break completely every import < 2.6 |
| src/kirigamiplugin.cpp | ||
|---|---|---|
| 173 ↗ | (On Diff #38964) | So, should it be registered for both versions 2.2 and 2.6? |
| src/kirigamiplugin.cpp | ||
|---|---|---|
| 173 ↗ | (On Diff #38964) | |
| src/kirigamiplugin.cpp | ||
|---|---|---|
| 173 ↗ | (On Diff #38964) | Register it just for 2.2 and forget about revisions. |