Differential D14544

Android: Don't hardcode a random version of the Android SDK
ClosedPublic
Actions

Authored by apol on Aug 2 2018, 12:10 AM.

Details

Reviewers
vkrause
Group Reviewers
Frameworks
Commits
R240:2f9bf6673179: Android: Don't hardcode a random version of the Android SDK
Summary

Just default to whichever is installed

Test Plan

Built kalgebra

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Aug 2 2018, 12:10 AM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptAug 2 2018, 12:10 AM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Aug 2 2018, 12:10 AM
alexeymin added a subscriber: alexeymin.EditedAug 2 2018, 6:47 AM

From all of my installed build tools: 19.1.0, 20.0.0, 21.1.2, 22.0.1, 23.0.1, 23.0.2, 23.0.3, 24.0.0, 26.0.1 it selects _default_sdk as 19.1.0, is it fine? 😄
I mean, which one should be used ideally?

vkrause accepted this revision.Aug 2 2018, 8:25 AM
This revision is now accepted and ready to land.Aug 2 2018, 8:25 AM
apol added a comment.Aug 2 2018, 10:31 AM
In D14544#302017, @alexeymin wrote:

From all of my installed build tools: 19.1.0, 20.0.0, 21.1.2, 22.0.1, 23.0.1, 23.0.2, 23.0.3, 24.0.0, 26.0.1 it selects _default_sdk as 19.1.0, is it fine? 😄
I mean, which one should be used ideally?

I guess in your case you will have to pass -DANDROID_SDK_BUILD_TOOLS_REVISION, but note that you don't even have installed the one we have now.

Closed by commit R240:2f9bf6673179: Android: Don't hardcode a random version of the Android SDK (authored by apol). · Explain WhyAug 2 2018, 10:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtoolchain/Android.cmake (5 lines)

Diff 38937

View Options

toolchain/Android.cmake

Loading...