| ngraham |
| KWin | |
| Plasma | |
| VDG |
We have two exclusive categories in the Appearance category:
minimize-animations and show-desktop. But it's hard to draw a line
between them, i.e. one can't say whether given effect belongs to the
minimize-animations category or to the show-desktop category.
This change moves show desktop effects to their own category so we have only
one exclusive category in the Appearance category.
Before:
After:
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
If the new category is going to be called "Window Minimize Animation", we should probably rename the effect that's currently named "Minimize Animation". :)
Also, keep in mind that I'm not a native English speaker. So, if you think that "Window Minimize Animation" is broken English, I'm open for suggestions.
Yeah, I also had the same thought. I can't call it "scale" because it behaves more like "morph": https://www.youtube.com/watch?v=Lh5VS7Sopws
Anyway, I'm open for suggestions. :-)
The section header text is fine, we just shouldn't use the same wording for one of its child items. I'd be in favor of calling the effect "Scale" or "Scale Down", Other ideas: "Squash", "Shrink".
Agree.
I'd be in favor of calling the effect "Scale" or "Scale Down", Other ideas: "Squash", "Shrink".
The Minimize Animation effect doesn't behave like this https://www.youtube.com/watch?v=KX2U4w7k7ks, so we can't name it "Scale".
But I really like "Squash". Still, we need to hear opinion of @graesslin and @davidedmundson.
Also, please notice that renaming the minimize animation effect can't go in this patch. It should go in a different one.
IMHO the name doesn't need to be perfectly technically accurate. It only needs to be descriptive enough to convey the effect's general appearance (is "Magic Lamp" totally accurate? What does that even mean?). I have no strong opinion regarding the ultimate wording as long as we change it to something else so it doesn't duplicate the new header text, so I'll let others make the final decision here.
Also, please notice that renaming the minimize animation effect can't go in this patch. It should go in a different one.
Right, I'm just saying that IMHO we shouldn't do this until we've achieved consensus on the renaming and we have the patch for it ready to go.
Hmm, after thinking for a while, I think it would be better to move show desktop effects to their own category. That way, we can leave minimize effects as they are.
Anyway, I'll rework this patch.
Actually, anywhere we have an exclusive group, I'd prefer that it has it own category, because then we can give the group a proper label. Alternatively, we could figure out a way to give exclusive groups their own label within their parent category, Right now it's sort of confusing to have effects with radio buttons just sitting there alongside the other effects that have checkboxes.
What should we do with this one? I'm in favor of moving show desktop effects to their own category. I think it's sensible because we already have something similar for virtual desktop switching effects.
Right now it's sort of confusing to have effects with radio buttons just sitting there alongside the other effects that have checkboxes.
I completely agree, but we can't right now nicely categorize all effects. Let's take a small step towards the goal.