[kcmkwin/compositing] Move show desktop effects to their own category
ClosedPublic

Authored by zzag on Sun, Jul 29, 2:48 PM.

Details

Summary

We have two exclusive categories in the Appearance category:
minimize-animations and show-desktop. But it's hard to draw a line
between them, i.e. one can't say whether given effect belongs to the
minimize-animations category or to the show-desktop category.

This change moves show desktop effects to their own category so we have only
one exclusive category in the Appearance category.

Before:

After:

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Sun, Jul 29, 2:48 PM
Restricted Application added a project: KWin. · View Herald TranscriptSun, Jul 29, 2:48 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Sun, Jul 29, 2:48 PM
ngraham added a subscriber: ngraham.EditedSun, Jul 29, 2:50 PM

If the new category is going to be called "Window Minimize Animation", we should probably rename the effect that's currently named "Minimize Animation". :)

zzag edited the summary of this revision. (Show Details)Sun, Jul 29, 2:51 PM
zzag added a comment.Sun, Jul 29, 2:56 PM

If the new category is going to be called "Window Minimize Animation", we should probably rename the effect that's currently named "Window Minimize Animation". :)

Also, keep in mind that I'm not a native English speaker. So, if you think that "Window Minimize Animation" is broken English, I'm open for suggestions.

Yeah, I also had the same thought. I can't call it "scale" because it behaves more like "morph": https://www.youtube.com/watch?v=Lh5VS7Sopws

Anyway, I'm open for suggestions. :-)

The section header text is fine, we just shouldn't use the same wording for one of its child items. I'd be in favor of calling the effect "Scale" or "Scale Down", Other ideas: "Squash", "Shrink".

The section header text is fine, we just shouldn't use the same wording for one of its child items.

Agree.

I'd be in favor of calling the effect "Scale" or "Scale Down", Other ideas: "Squash", "Shrink".

The Minimize Animation effect doesn't behave like this https://www.youtube.com/watch?v=KX2U4w7k7ks, so we can't name it "Scale".
But I really like "Squash". Still, we need to hear opinion of @graesslin and @davidedmundson.

Also, please notice that renaming the minimize animation effect can't go in this patch. It should go in a different one.

In D14458#300083, @zzag wrote:

The Minimize Animation effect doesn't behave like this https://www.youtube.com/watch?v=KX2U4w7k7ks, so we can't name it "Scale".
But I really like "Squash". Still, we need to hear opinion of @graesslin and @davidedmundson.

IMHO the name doesn't need to be perfectly technically accurate. It only needs to be descriptive enough to convey the effect's general appearance (is "Magic Lamp" totally accurate? What does that even mean?). I have no strong opinion regarding the ultimate wording as long as we change it to something else so it doesn't duplicate the new header text, so I'll let others make the final decision here.

Also, please notice that renaming the minimize animation effect can't go in this patch. It should go in a different one.

Right, I'm just saying that IMHO we shouldn't do this until we've achieved consensus on the renaming and we have the patch for it ready to go.

zzag added a comment.Sun, Jul 29, 7:00 PM

Hmm, after thinking for a while, I think it would be better to move show desktop effects to their own category. That way, we can leave minimize effects as they are.

Anyway, I'll rework this patch.

Actually, anywhere we have an exclusive group, I'd prefer that it has it own category, because then we can give the group a proper label. Alternatively, we could figure out a way to give exclusive groups their own label within their parent category, Right now it's sort of confusing to have effects with radio buttons just sitting there alongside the other effects that have checkboxes.

zzag updated this revision to Diff 38724.Sun, Jul 29, 7:08 PM

Move show desktop effects to their own category

zzag retitled this revision from [kcmkwin/compositing] Move minimize effects to their own category to [kcmkwin/compositing] Move show desktop effects to their own category.Sun, Jul 29, 7:09 PM
zzag edited the summary of this revision. (Show Details)
zzag added a comment.Sun, Jul 29, 7:34 PM
This comment was removed by zzag.
zzag added a comment.Sun, Jul 29, 7:38 PM
This comment was removed by zzag.
zzag added a comment.Tue, Jul 31, 1:23 PM

What should we do with this one? I'm in favor of moving show desktop effects to their own category. I think it's sensible because we already have something similar for virtual desktop switching effects.

Right now it's sort of confusing to have effects with radio buttons just sitting there alongside the other effects that have checkboxes.

I completely agree, but we can't right now nicely categorize all effects. Let's take a small step towards the goal.

ngraham accepted this revision.Tue, Jul 31, 1:36 PM

I agree.

This revision is now accepted and ready to land.Tue, Jul 31, 1:36 PM

I say go for it.

This revision was automatically updated to reflect the committed changes.