Differential D14395

[KSambaShare] Check file that's changed before reloading
ClosedPublic
Actions

Authored by broulik on Jul 26 2018, 7:51 AM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:a9b4eded78e8: [KSambaShare] Check file that's changed before reloading
Summary

We use the KDirWatch singleton so we might get signals for files we're not interested in

Test Plan

Dolphin no longer constantly reloads samba configuration while copying a directory.
sync() is still called once when I change Samba share settings in file properties dialog.
The view does not update the shared badge automatically but that also doesn't work without this patch so is a separate bug

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 26 2018, 7:51 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 26 2018, 7:51 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Jul 26 2018, 7:51 AM
dfaure accepted this revision.Jul 26 2018, 1:06 PM

Well spotted.

This revision is now accepted and ready to land.Jul 26 2018, 1:06 PM
Closed by commit R241:a9b4eded78e8: [KSambaShare] Check file that's changed before reloading (authored by broulik). · Explain WhyJul 26 2018, 1:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/ksambashare.cpp (5 lines)

Diff 38508

View Options

src/core/ksambashare.cpp

Loading...