This patch adds a feature to hide fully translated files and folders on the project tab.
Three ways to do that :
- In the menu bar
- In the "Go" menu
- With shortcut Ctrl+T
FEATURE: 224179
aacid | |
ltoscano | |
shaforostoff | |
mlaurent | |
huftis |
Localization |
This patch adds a feature to hide fully translated files and folders on the project tab.
Three ways to do that :
FEATURE: 224179
No Linters Available |
No Unit Test Coverage |
Buildable 1110 | |
Build 1123: arc lint + arc unit |
src/project/projectmodel.cpp | ||
---|---|---|
719 | What's the difference between this and FuzzyUntrCountRole ? | |
src/project/projectwidget.cpp | ||
155 | You still need to move the { down. | |
518 | Can you try with invalidateFilter ? Reading the documentation it seems it would make more sense. Also IMHO it makes more sense to call this inside toggletranslatedfiles than here. |
The patch adds a toolbar item, but itβs missing an icon. Could you add one? I think the one named hide_table_row will work well.
Also make sure to mention bug #224179 in the revision summary, so that it will automatically be closed when you commit the revision. See https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords for instructions.
I have done some testing, and the patch seems to work fine. Thanks for adding this very useful feature!
src/project/projectmodel.cpp | ||
---|---|---|
719 | You marked this as done but didn't give me an answer? |
src/project/projectmanagerui.rc | ||
---|---|---|
17 | Why is this on the "Go" menu instead of on the "Settings" menu? To me it seems it would make more sense in settings. | |
src/project/projecttab.cpp | ||
183 | it also hides folders, though adding it probably makes it too long (at least for the toolbar). I think there's two ways a) This way the toolbar doesn't have the "and folders" but the menu does, saves some space on the toolbar but not on the menu since on the menu is less needed (though it can be a bit confusing to users the fact that there's two different texts for the same action) b) So the tooltip on the toolbar gives some more info. What do you think? Or am i making a big deal of nothing? π |
src/project/projectmanagerui.rc | ||
---|---|---|
17 | ok, it could be in Project as well, I don't have a strong preference on this one so I'll follow your advice. | |
src/project/projecttab.cpp | ||
183 | Why not both ? I was thinking of something like "items" instead of "files and folders" but it would be more confusing, some people may think it would hide the translated strings within the files. |
src/project/projecttab.cpp | ||
---|---|---|
183 | I donΒ΄t think it is a bad idea to use "files", "items" or "content" on the text as long as the tooltip clarifies. Also, on the menu entry I would consider even removing the "fully" part, or replace "fully translated" by something shorter, like "complete" or "done". |
src/project/projecttab.cpp | ||
---|---|---|
183 | So "Hide completed items" for the text and "Hide fully translated files and folders" for the tooltip should be ok for everyone I hope. |
I didn't plan that, the quick search project field isn't saved between runs.
Performance wise it would not change anything to launch the program with the filter on.