Differential D14131

Add enum alias Property::Language for typo Property::Langauge
ClosedPublic
Actions

Authored by kossebau on Jul 15 2018, 12:06 PM.

Details

Reviewers

mgallien

Commits

R286:0f5a6c892473: Add enum alias Property::Language for typo Property::Langauge

Test Plan

Unit tests still pass, Dolphin still shows the right file metadata

Diff Detail

Repository

R286 KFileMetaData

Branch

fixLangaugeEnumTypoNow

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 866
Build 879: arc lint + arc unit

kossebau created this revision.Jul 15 2018, 12:06 PM

Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJul 15 2018, 12:06 PM

Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript

kossebau requested review of this revision.Jul 15 2018, 12:06 PM

Harbormaster completed remote builds in B866: Diff 37798.Jul 15 2018, 12:06 PM

Looks good to me. If @mgallien doesn't give you an "accept" in a reasonable timeframe i guess you can count this as me accepting it ;)

In D14131#294528, @aacid wrote:

Looks good to me. If @mgallien doesn't give you an "accept" in a reasonable timeframe i guess you can count this as me accepting it ;)

I am in holidays for 3 weeks and unable to properly review anything. Sorry.
By the way, is there a KDE wide service to indicate vacancies ?

There is no KDE wide service to indicate absences or unavailability at the moment i'm afraid.

@mgallien Enjoy your vacations :) Not a pressing issue, just some TODO which could be fixed already now and which I saw while stumpling about the same typo elsewhere. So fine with me to only handle once you are back.

Thanks for your work and good idea.

This revision is now accepted and ready to land.Aug 11 2018, 5:24 PM

Closed by commit R286:0f5a6c892473: Add enum alias Property::Language for typo Property::Langauge (authored by kossebau). · Explain WhyAug 11 2018, 5:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/office2007extractortest.cpp (2 lines)
M			autotests/taglibextractortest.cpp (10 lines)
M			src/extractors/odfextractor.cpp (2 lines)
M			src/extractors/office2007extractor.cpp (2 lines)
M			src/extractors/taglibextractor.cpp (2 lines)
M			src/properties.h (9 lines)
M			src/propertyinfo.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	37798	40c7821		Jul 15 2018, 12:06 PM	★	★
Diff 2	39468	c9ab471	R286:0f5a6c892473badc7be12fb44b13384709e3a4f7	Aug 11 2018, 5:56 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
253454c7b78d	4dae3229cc0b	40c78210c79f	Friedrich W. H. Kossebau	Add enum alias Property::Language for typo Property::Langauge (Show More…)	Jul 15 2018, 11:34 AM