Differential D14121

KFormat: Add unit tests for mili/micro SI prefixes
ClosedPublic
Actions

Authored by bruns on Jul 15 2018, 12:51 AM.

Details

Reviewers
kossebau
astippich
Group Reviewers
Frameworks
Commits
R244:b95bfd7e47a3: KFormat: Add unit tests for mili/micro SI prefixes
Summary

Add test cases for KFormat::formatValue(...) with value smaller than
1.0, with fixed and automatic SI prefix.

Diff Detail

Repository
R244 KCoreAddons
Branch
test1
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 874
Build 887: arc lint + arc unit
bruns created this revision.Jul 15 2018, 12:51 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 15 2018, 12:51 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Jul 15 2018, 12:51 AM
astippich accepted this revision.Jul 15 2018, 10:50 AM
astippich added a subscriber: astippich.

test itself is fine, but I spotted a typo.

autotests/kformattest.cpp
118

typo: KFormat::UnitPrefix::Mil_l_i . Should be safe to change it since it hasn't been released in its current state, isn't it?

This revision is now accepted and ready to land.Jul 15 2018, 10:50 AM
bruns updated this revision to Diff 37808.Jul 15 2018, 3:12 PM

update after typo fix

bruns marked an inline comment as done.Jul 15 2018, 3:36 PM
bruns added inline comments.
autotests/kformattest.cpp
118

see D14135

Closed by commit R244:b95bfd7e47a3: KFormat: Add unit tests for mili/micro SI prefixes (authored by bruns). · Explain WhyJul 15 2018, 4:10 PM
This revision was automatically updated to reflect the committed changes.
bruns marked an inline comment as done.

Revision Contents
Changeset List

PathPackages
Mautotests/kformattest.cpp (4 lines)

Diff 37808

View Options

autotests/kformattest.cpp

Loading...