Find KF5I18n in the top-level CMakeLists.txt

Authored by heikobecker on Jul 12 2018, 8:34 AM.



I'm not entirely sure why ki18n_install() (added on tarball
generation) is even known at that moment, but since 3e44fb7 in ki18n
I get "CMake Error: No script specified for argument -P" when
generating ts files, apparently because
_ki18n_build_{ts,po}files_script end up empty.
In any case finding stuff before trying to use it seems sensible
and adding the find_package call before ki18n_install indeed fixes
the problem.

Test Plan

Tested with ki18n-5.48.0 and the kde-dev-util tarball

Diff Detail

R451 KDE Development Utils
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
heikobecker requested review of this revision.Jul 12 2018, 8:34 AM
heikobecker created this revision.

I confirm necessity w/ >=KF-5.48 and that the fix is working.

+1 otherwise kde-dev-utils fails to package on FreeBSD too with 5.48.

ditto for Kubuntu

ltoscano accepted this revision as: ltoscano.Jul 15 2018, 1:27 PM

It makes sense; probably some change in KI18n uncovered this, as it was working for a while.

This revision is now accepted and ready to land.Jul 15 2018, 1:27 PM
This revision was automatically updated to reflect the committed changes.